-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Update tests to reflect new in-memory hashing vs. coarser dag_hash.
- Spack currently not hashing build deps (to allow more reuse of packages and less frequent re-installing) - Fast in-memory hash should still hash *all* deptypes, and installed specs will only reflect link and run deps. - We'll revert this when we can concretize more liberally based on what is already installed.
- Loading branch information
Showing
1 changed file
with
18 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tgamblin Just to double check. As I am converting tests I found a couple of
self.assertTrue
that were clearly meant to beself.assertEqual
. The APIs onunittest
is kind of sneaky, because if you take the wrong assertion, the call is still valid:Here it seems it makes sense to
assertTrue
, but I was wondering: do you want the error message to bespec_from_file
or was it a cut and paste error from the line above?