Skip to content

Commit

Permalink
Add -d and -j options to diy
Browse files Browse the repository at this point in the history
Also add -j to the common arguments
  • Loading branch information
krafczyk committed Jan 7, 2017
1 parent f379697 commit e1451ee
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 4 deletions.
4 changes: 4 additions & 0 deletions lib/spack/spack/cmd/common/arguments.py
Original file line number Diff line number Diff line change
Expand Up @@ -105,3 +105,7 @@ def _specs(self, **kwargs):
_arguments['very_long'] = Args(
'-L', '--very-long', action='store_true',
help='Show full dependency hashes as well as versions.')

_arguments['jobs'] = Args(
'-j', '--jobs', action='store', type=int, dest="jobs",
help="Explicitly set number of make jobs. Default is #cpus.")
16 changes: 15 additions & 1 deletion lib/spack/spack/cmd/diy.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@


def setup_parser(subparser):
arguments.add_common_arguments(subparser, ['jobs'])
subparser.add_argument(
'-d', '--source-path', dest='source_path', default=None,
help="Path to the source directory. Defaults to the current directory")
subparser.add_argument(
'-i', '--ignore-dependencies', action='store_true', dest='ignore_deps',
help="Do not try to install dependencies of requested packages.")
Expand All @@ -62,6 +66,10 @@ def diy(self, args):
if not args.spec:
tty.die("spack diy requires a package spec argument.")

if args.jobs is not None:
if args.jobs <= 0:
tty.die("The -j option must be a positive integer!")

specs = spack.cmd.parse_specs(args.spec)
if len(specs) > 1:
tty.die("spack diy only takes one spec.")
Expand Down Expand Up @@ -91,13 +99,19 @@ def diy(self, args):
tty.msg("Uninstall or try adding a version suffix for this DIY build.")
sys.exit(1)

source_path = args.source_path
if source_path is None:
source_path = os.getcwd()
source_path = os.path.abspath(source_path)

# Forces the build to run out of the current directory.
package.stage = DIYStage(os.getcwd())
package.stage = DIYStage(source_path)

# TODO: make this an argument, not a global.
spack.do_checksum = False

package.do_install(
make_jobs=args.jobs,
keep_prefix=args.keep_prefix,
install_deps=not args.ignore_deps,
verbose=not args.quiet,
Expand Down
4 changes: 1 addition & 3 deletions lib/spack/spack/cmd/install.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,7 @@ def setup_parser(subparser):
Alternatively one can decide to install only the package or only
the dependencies."""
)
subparser.add_argument(
'-j', '--jobs', action='store', type=int,
help="Explicitly set number of make jobs. Default is #cpus.")
arguments.add_common_arguments(subparser, ['jobs'])
subparser.add_argument(
'--keep-prefix', action='store_true', dest='keep_prefix',
help="Don't remove the install prefix if installation fails.")
Expand Down

0 comments on commit e1451ee

Please sign in to comment.