Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Installation issue: gcc@7.3.0 #16968

Closed
4 tasks done
jjolly opened this issue Jun 5, 2020 · 4 comments · Fixed by #16969
Closed
4 tasks done

Installation issue: gcc@7.3.0 #16968

jjolly opened this issue Jun 5, 2020 · 4 comments · Fixed by #16969
Labels
build-error

Comments

@jjolly
Copy link
Contributor

jjolly commented Jun 5, 2020

Steps to reproduce the issue

From Ubuntu 20.04 with gcc 9.3.0 installed

$ spack install gcc@7.3.0
...
In file included from /tmp/jjolly/spack-stage/spack-stage-gcc-7.3.0-qew2co74raqn36lqlwarwxe7pn6vq63n/spack-src/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc:190:0:
/tmp/jjolly/spack-stage/spack-stage-gcc-7.3.0-qew2co74raqn36lqlwarwxe7pn6vq63n/spack-src/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:261:72: error: size of array 'assertion_failed__1150' is negative
     typedef char IMPL_PASTE(assertion_failed_##_, line)[2*(int)(pred)-1]
                                                                        ^
/tmp/jjolly/spack-stage/spack-stage-gcc-7.3.0-qew2co74raqn36lqlwarwxe7pn6vq63n/spack-src/libsanitizer/sanitizer_common/sanitizer_internal_defs.h:255:30: note: in expansion of macro 'IMPL_COMPILER_ASSERT' #define COMPILER_CHECK(pred) IMPL_COMPILER_ASSERT(pred, __LINE__)
                              ^~~~~~~~~~~~~~~~~~~~
/tmp/jjolly/spack-stage/spack-stage-gcc-7.3.0-qew2co74raqn36lqlwarwxe7pn6vq63n/spack-src/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.h:1461:3: note: in expansion of macro 'COMPILER_CHECK'
   COMPILER_CHECK(sizeof(((__sanitizer_##CLASS *) NULL)->MEMBER) == \
   ^~~~~~~~~~~~~~
/tmp/jjolly/spack-stage/spack-stage-gcc-7.3.0-qew2co74raqn36lqlwarwxe7pn6vq63n/spack-src/libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cc:1150:1: note: in expansion of macro 'CHECK_SIZE_AND_OFFSET'
 CHECK_SIZE_AND_OFFSET(ipc_perm, mode);
 ^~~~~~~~~~~~~~~~~~~~~
make[4]: *** [Makefile:523: sanitizer_platform_limits_posix.lo] Error 1

Information on your system

$ spack debug report
* **Spack:** 0.14.2-1341-2ec680bbf
* **Python:** 3.8.2
* **Platform:** linux-ubuntu20.04-x86_64

Additional information

gcc maintainer: @michaelkuhn

General information

  • I have run spack debug report and reported the version of Spack/Python/Platform
  • I have run spack maintainers <name-of-the-package> and @mentioned any maintainers
  • I have uploaded the build log and environment files
  • I have searched the issues of this repo and believe this is not a duplicate
@jjolly
Copy link
Contributor Author

jjolly commented Jun 5, 2020

I have backported patches that fix the issue for gcc@5.3.0:7.4.0. PR to follow shortly.

jjolly added a commit to jjolly/spack that referenced this issue Jun 5, 2020
@jjolly
gcc: Fix error 'size of array is negative' (spack#16968)
6fb6b28 
gcc 9.3.0 and glibc 2.31 (found in the base install of Ubuntu 20.04)
cause the gcc package to error during build with the error:

    "size of array 'assertion_failed__####' is negative"

Previous to this fix, the error was resolved for v8.1.0 <= gcc <= v9.2.0
via two patches.

This fix backports those patches for v5.3.0 <= gcc <= v7.4.0

Potentially these patches need to be backported to versions of gcc
before v5.3.0, but other compile issues need to be resolved for earlier
versions of gcc first.
@michaelkuhn michaelkuhn mentioned this issue Jun 5, 2020
Merged
jjolly added a commit to jjolly/spack that referenced this issue Jun 5, 2020
@jjolly
gcc: Fix error 'size of array is negative'
6f6a1d3 
gcc 9.3.0 and glibc 2.31 (found in the base install of Ubuntu 20.04)
cause the gcc package to error during build with the error:

    "size of array 'assertion_failed__####' is negative"

Previous to this fix, the error was resolved for v8.1.0 <= gcc <= v9.2.0
via two patches.

This fix backports those patches for v5.3.0 <= gcc <= v7.4.0

Potentially these patches need to be backported to versions of gcc
before v5.3.0, but other compile issues need to be resolved for earlier
versions of gcc first.

Fixes spack#16968
adamjstewart pushed a commit that referenced this issue Jun 6, 2020
@jjolly
gcc: Fix error 'size of array is negative' (#16969)
46a7510 
gcc 9.3.0 and glibc 2.31 (found in the base install of Ubuntu 20.04)
cause the gcc package to error during build with the error:

    "size of array 'assertion_failed__####' is negative"

Previous to this fix, the error was resolved for v8.1.0 <= gcc <= v9.2.0
via two patches.

This fix backports those patches for v5.3.0 <= gcc <= v7.4.0

Potentially these patches need to be backported to versions of gcc
before v5.3.0, but other compile issues need to be resolved for earlier
versions of gcc first.

Fixes #16968
manifestoso pushed a commit to DeepThoughtHPC/spack that referenced this issue Jun 19, 2020
@jjolly @manifestoso
gcc: Fix error 'size of array is negative' (spack#16969)
29b9b4f 
gcc 9.3.0 and glibc 2.31 (found in the base install of Ubuntu 20.04)
cause the gcc package to error during build with the error:

    "size of array 'assertion_failed__####' is negative"

Previous to this fix, the error was resolved for v8.1.0 <= gcc <= v9.2.0
via two patches.

This fix backports those patches for v5.3.0 <= gcc <= v7.4.0

Potentially these patches need to be backported to versions of gcc
before v5.3.0, but other compile issues need to be resolved for earlier
versions of gcc first.

Fixes spack#16968
@vsoch
Copy link
Member

vsoch commented Nov 6, 2021

I think we just hit this error, but for an older gcc install attempt. Note that it was working before:

https://github.com/rse-ops/docker-images/runs/4123921483?check_suite_focus=true

How do we fix it? cc @davidbeckingsale

@davidbeckingsale
Copy link
Contributor

I think that our problem was caused by using Ubuntu 22.04. Backporting the fixes to old versions can be quite challenging, might not be worth it.

@vsoch
Copy link
Member

vsoch commented Nov 8, 2021

Huh, how did we get a 22 04? I thought the release date would be April 2022? Did we time travel? 😆

krasCGQ added a commit to krasCGQ/build-tools-gcc that referenced this issue Sep 3, 2022
@krasCGQ
build: Patch GCC 6/7 with backports for Glibc 2.31+ compatibility
cf26019 
Toolchain build for targets other than AArch64 break due to changes mentioned
since that affromentioned release. This is not an issue with 8.4.0, 9.3.0 and
later builds.

Patches are taken from AUR, but I have to clean up GCC 6 one somehow.

Link: https://bugs.gentoo.org/708346
Link: spack/spack#16968
Link: https://aur.archlinux.org/packages/gcc6
Link: https://aur.archlinux.org/packages/gcc7
Signed-off-by: Albert I <kras@raphielgang.org>
krasCGQ added a commit to krasCGQ/build-tools-gcc that referenced this issue Sep 3, 2022
@krasCGQ
build: Patch GCC 6/7 with backports for Glibc 2.31+ compatibility
808ed42 
Toolchain build for targets other than AArch64 break due to changes mentioned
since that affromentioned release. This is not an issue with 8.4.0, 9.3.0 and
later builds.

Patches are taken from AUR, but I have to clean up GCC 6 one somehow.

Link: https://bugs.gentoo.org/708346
Link: spack/spack#16968
Link: https://aur.archlinux.org/packages/gcc6
Link: https://aur.archlinux.org/packages/gcc7
Signed-off-by: Albert I <kras@raphielgang.org>
krasCGQ added a commit to krasCGQ/build-tools-gcc that referenced this issue Sep 4, 2022
@krasCGQ
build: Patch GCC 6/7 with backports for Glibc 2.31+ compatibility
3a06f1d 
Toolchain build for targets other than AArch64 break due to changes mentioned
since that affromentioned release. This is not an issue with 8.4.0, 9.3.0 and
later builds.

Patches are taken from AUR, but I have to clean up GCC 6 one somehow.

Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92154
Link: https://bugs.gentoo.org/708346
Link: spack/spack#16968
Link: https://aur.archlinux.org/packages/gcc6
Link: https://aur.archlinux.org/packages/gcc7
Signed-off-by: Albert I <kras@raphielgang.org>
krasCGQ added a commit to krasCGQ/build-tools-gcc that referenced this issue Sep 4, 2022
@krasCGQ
build: Patch GCC 6/7 with backports for Glibc 2.31+ compatibility
e0a575b 
Toolchain build for targets other than AArch64 break due to changes mentioned
since that affromentioned release. This is not an issue with 8.4.0, 9.3.0 and
later builds.

Patches are taken from AUR, but I have to clean up GCC 6 one somehow.

Link: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92154
Link: https://bugs.gentoo.org/708346
Link: spack/spack#16968
Link: https://aur.archlinux.org/packages/gcc6
Link: https://aur.archlinux.org/packages/gcc7
Signed-off-by: Albert I <kras@raphielgang.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-error
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gcc: Fix error 'size of array is negative' (#16968) jjolly/spack
3 participants
@jjolly @davidbeckingsale @vsoch