-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trilinos recipe: spec['blas'].prefix.lib is wrong for mkl #1923
Comments
Specs are marked external so we have the information. May need to record it better. |
you can't use external MKL, you should build it with Spack, then symlinks will be created. That way Trilinos is buildable with MKL. |
p.s. tested on on Ubuntu@16.04+gcc@5.4.0 in this PR #1852 |
I think we need to make external MKL work. A lot of users will already have it installed. Can't we search for libraries recursively instead of asserting that they have to be in |
essentially that would amount to changing everywhere |
do you want to try this for |
@KineticTheory For the record, this is a modification that should be made in the |
Not exactly. It should be done in both places.
and in
already searches in native directory structure. One can then remove
from |
p.s. symlinking was introduced prior to #1682 . |
With the new LAPACK/BLAS functionality do we need symlinking? I think depending on the native directory structure for externals is better. |
we don't need to symlink. It is indeed good to avoid it everywhere. |
…ctory. + This change fixes a problem that manifests when trilinos is built against a MKL installation defined as an external package. In this scenario, the MKL libraries are found one directory deeper than for the case where spack provides MKL. The extra directory is a platform name like 'intel64'. + The changes in this PR were recommended by contributor @davydden. I implemented and tested with intel@16.0.3. These changes fix the issue I reported. I did not attempt building trilinos against other BLAS implementations. + fixes spack#1923
…ctory. (#1987) + This change fixes a problem that manifests when trilinos is built against a MKL installation defined as an external package. In this scenario, the MKL libraries are found one directory deeper than for the case where spack provides MKL. The extra directory is a platform name like 'intel64'. + The changes in this PR were recommended by contributor @davydden. I implemented and tested with intel@16.0.3. These changes fix the issue I reported. I did not attempt building trilinos against other BLAS implementations. + fixes #1923
I can no longer build
trilinos ^mkl
becausespec['blas'].prefix.lib
does not point to the correct directory for MKL. At least for my installation, the MKL libraries are located at$MKLROOT/lib/intel64
and not at$MKLROOT/lib
. I'm not sure how to fix this because I don't know if there is significant variation in directory names for MKL installations.It is simple to modify the trilinos recipe to do something special for MKL. Should I submit a PR with these changes? Does anyone else have experience building trilinos against MKL? Are there other configurations that I should be aware of?
The text was updated successfully, but these errors were encountered: