Installation issue: silo

[cessenat]

Steps to reproduce the issue

Since hdf5 1.10 is no longer preferred (commit #28091 from @haampie )
and since constraint to hdf5@:1.10 in silo package is no longer enforced (commit #27613 from @lrknox )
Silo does not compile any longer:
$ spack install silo~mpi %gcc

==> Warning: the original concretizer is currently being used.
	Upgrade to "clingo" at your earliest convenience. The original concretizer will be removed from Spack starting at v0.18.0
[+] /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/libsigsegv-2.13-26tzm7qfxttvhnjqbcveo3cw5ooij2uv
[+] /usr (external perl-5.26.1-l4f2oz7dlfuprlys6w6gzufklzllko3k)
[+] /usr (external ncurses-6.1.20180127-ylf3xgjqk3f4xn4uvu6qqluilqirwfb3)
[+] /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/zlib-1.2.11-whj3n7mok67wqtm5dofead56i6krevxc
==> intel-oneapi-mpi@2021.5.0 : has external module in ['mpi/latest']
[+] /opt/intel/oneapi (external intel-oneapi-mpi-2021.5.0-hwyyuef4h35d4wewrxbdjigkx2gdf74e)
[+] /usr (external pkg-config-0.29.1-6ckknx5vxngysijpqpmsqgxtmwmyoias)
[+] /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/m4-1.4.19-jjj5iyn4zjlao7tsfz3pcewldktu3iyw
[+] /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/readline-8.1-4fdtglszlz2wjtc3pogbkyav7sn5j6zx
[+] /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/openssl-1.1.1m-23imk2rsftvme5mwrkr6wdvhoecqq2rk
[+] /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/libtool-2.4.6-63ex67yxwgibeklyc7ym2cxoqu3c4fep
[+] /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/autoconf-2.69-nihz3kucoftzj6n4pepwswye4bytb2ts
[+] /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/cmake-3.22.1-2bmrk6wtskjchznutvum6jwafsu37oym
[+] /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/automake-1.16.5-lsjim52ze4ghh65vyz5tubc2svrfe6er
[+] /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/hdf5-1.12.1-n5vn6kguza6zyjvxyt77z2ehzl44yfp5
==> Installing silo-4.10.2-vlgacj4rmtixtudik6myfm2ho7qvbuz2
==> No binary for silo-4.10.2-vlgacj4rmtixtudik6myfm2ho7qvbuz2 found: installing from source
==> Using cached archive: /home2/cessenat/Softs/spack/var/spack/cache/_source-cache/archive/3a/3af87e5f0608a69849c00eb7c73b11f8422fa36903dd14610584506e7f68e638.tgz
==> Applied patch /home2/cessenat/Softs/spack/var/spack/repos/builtin/packages/silo/remove-mpiposix.patch
==> Applied patch /home2/cessenat/Softs/spack/var/spack/repos/builtin/packages/silo/H5FD_class_t-terminate.patch
==> silo: Executing phase: 'autoreconf'
==> silo: Executing phase: 'configure'
==> silo: Executing phase: 'build'
==> Error: ProcessError: Command exited with status 2:
    'make' '-j6' 'V=1'

129 errors found in build log:
     20      libtoolize: copying file 'config/lt~obsolete.m4'
     21      libtoolize: Consider adding 'AC_CONFIG_MACRO_DIRS([config])' to configure.ac,
     22      libtoolize: and rerunning libtoolize and aclocal.
     23      autoreconf: running: /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/autoconf-2.69-nihz3kucoftzj6n4p
             epwswye4bytb2ts/bin/autoconf --include=/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/automake-1.16
             .5-lsjim52ze4ghh65vyz5tubc2svrfe6er/share/aclocal --include=/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gc
             c-9.3.0/libtool-2.4.6-63ex67yxwgibeklyc7ym2cxoqu3c4fep/share/aclocal --force
     24      autoreconf: running: /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/autoconf-2.69-nihz3kucoftzj6n4p
             epwswye4bytb2ts/bin/autoheader --include=/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/automake-1.
             16.5-lsjim52ze4ghh65vyz5tubc2svrfe6er/share/aclocal --include=/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/
             gcc-9.3.0/libtool-2.4.6-63ex67yxwgibeklyc7ym2cxoqu3c4fep/share/aclocal --force
     25      autoreconf: running: automake --add-missing --copy --force-missing
  >> 26      configure.ac:367: installing 'config/compile'
  >> 27      configure.ac:170: installing 'config/missing'
     28      src/Makefile.am: installing 'config/depcomp'
     29      tests/Makefile.am:160: warning: variable 'bcastopen_SOURCES' is defined but no program or
  >> 30      tests/Makefile.am:160: library has 'bcastopen' as canonical name (possible typo)
     31      autoreconf: Leaving directory `.'
     32      ==> silo: Executing phase: 'configure'
     33      ==> [2022-01-14-07:22:00.497755] '/tmp/cessenat/spack-stage/spack-stage-silo-4.10.2-vlgacj4rmtixtudik6myfm2ho7qvbuz2/spack-
             src/configure' '--prefix=/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/silo-4.10.2-vlgacj4rmtixtud
             ik6myfm2ho7qvbuz2' '--enable-install-lite-headers' '--enable-fortran' '--disable-silex' '--enable-shared' '--enable-hzip' '
             --enable-fpzip' '--with-zlib=/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/zlib-1.2.11-whj3n7mok67
             wqtm5dofead56i6krevxc/include,/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/zlib-1.2.11-whj3n7mok6
             7wqtm5dofead56i6krevxc/lib' '--with-hdf5=/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/hdf5-1.12.1
             -n5vn6kguza6zyjvxyt77z2ehzl44yfp5/include,/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/hdf5-1.12.
             1-n5vn6kguza6zyjvxyt77z2ehzl44yfp5/lib'
     34      checking for a BSD-compatible install... /usr/bin/install -c
     35      checking whether build environment is sane... yes
     36      checking for a thread-safe mkdir -p... /usr/bin/mkdir -p

     ...

     530     libtool: compile:  /home2/cessenat/Softs/spack/lib/spack/env/gcc/gcc -DHAVE_CONFIG_H -I. -I../.. -I./../silo -I./../silo -I
             ./../hzip -I./../fpzip -I/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/hdf5-1.12.1-n5vn6kguza6zyjv
             xyt77z2ehzl44yfp5/include -I/home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/zlib-1.2.11-whj3n7mok67w
             qtm5dofead56i6krevxc/include -fPIC -D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 -Wdeclaration-after-sta
             tement -MT H5FDsilo.lo -MD -MP -MF .deps/H5FDsilo.Tpo -c H5FDsilo.c  -fPIC -DPIC -o .libs/H5FDsilo.o
     531     H5FDsilo.c:523:5: warning: initialization of 'haddr_t (*)(const H5FD_t *, H5FD_mem_t)' {aka 'long unsigned int (*)(const st
             ruct H5FD_t *, enum H5F_mem_t)'} from incompatible pointer type 'haddr_t (*)(const H5FD_t *)' {aka 'long unsigned int (*)(c
             onst struct H5FD_t *)'} [-Wincompatible-pointer-types]
     532       523 |     H5FD_silo_get_eof,                  /*get_eof  */
     533           |     ^~~~~~~~~~~~~~~~~
     534     H5FDsilo.c:523:5: note: (near initialization for 'H5FD_silo_g.get_eof')
     535     H5FDsilo.c: In function 'file_write':
  >> 536     H5FDsilo.c:259:1: error: expected ';' before '}' token
     537       259 | }
     538           | ^
     539     H5FDsilo.c:802:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     540       802 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW, "addr undefined", -1, -1)
     541           |         ^~~~~~~~~~~~~~~
  >> 542     H5FDsilo.c:259:1: error: expected ';' before '}' token
     543       259 | }
     544           | ^
     545     H5FDsilo.c:804:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     546       804 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW, "addr overflow", -1, -1)
     547           |         ^~~~~~~~~~~~~~~
  >> 548     H5FDsilo.c:259:1: error: expected ';' before '}' token
     549       259 | }
     550           | ^
     551     H5FDsilo.c:810:13: note: in expansion of macro 'H5E_PUSH_HELPER'
     552       810 |             H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_SEEKERROR, "HDlseek failed", -1, errno)
     553           |             ^~~~~~~~~~~~~~~
  >> 554     H5FDsilo.c:259:1: error: expected ';' before '}' token
     555       259 | }
     556           | ^
     557     H5FDsilo.c:822:13: note: in expansion of macro 'H5E_PUSH_HELPER'
     558       822 |             H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_WRITEERROR, "HDwrite failed", -1, errno)
     559           |             ^~~~~~~~~~~~~~~
  >> 560     H5FDsilo.c:848:15: error: invalid storage class for function 'file_read'
     561       848 | static herr_t file_read(H5FD_silo_t *file, haddr_t addr, size_t size, void *buf)
     562           |               ^~~~~~~~~
     563     H5FDsilo.c: In function 'file_read':
  >> 564     H5FDsilo.c:259:1: error: expected ';' before '}' token
     565       259 | }
     566           | ^
     567     H5FDsilo.c:861:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     568       861 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW, "addr undefined", -1, -1)
     569           |         ^~~~~~~~~~~~~~~
  >> 570     H5FDsilo.c:259:1: error: expected ';' before '}' token
     571       259 | }
     572           | ^
     573     H5FDsilo.c:863:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     574       863 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW, "addr overflow", -1, -1)
     575           |         ^~~~~~~~~~~~~~~
  >> 576     H5FDsilo.c:259:1: error: expected ';' before '}' token
     577       259 | }
     578           | ^
     579     H5FDsilo.c:869:13: note: in expansion of macro 'H5E_PUSH_HELPER'
     580       869 |             H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_IO, H5E_SEEKERROR, "HDlseek failed", -1, errno)
     581           |             ^~~~~~~~~~~~~~~
  >> 582     H5FDsilo.c:259:1: error: expected ';' before '}' token
     583       259 | }
     584           | ^
     585     H5FDsilo.c:881:13: note: in expansion of macro 'H5E_PUSH_HELPER'
     586       881 |             H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_IO, H5E_READERROR, "HDread failed", -1, errno)
     587           |             ^~~~~~~~~~~~~~~
  >> 588     H5FDsilo.c:910:15: error: invalid storage class for function 'file_write_block'
     589       910 | static herr_t file_write_block(H5FD_silo_t *file, int blidx)
     590           |               ^~~~~~~~~~~~~~~~
     591     H5FDsilo.c: In function 'file_write_block':
  >> 592     H5FDsilo.c:259:1: error: expected ';' before '}' token
     593       259 | }
     594           | ^
     595     H5FDsilo.c:925:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     596       925 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_WRITEERROR, "file_write_block failed", -1, -1)
     597           |         ^~~~~~~~~~~~~~~
  >> 598     H5FDsilo.c:952:15: error: invalid storage class for function 'file_read_block'
     599       952 | static herr_t file_read_block(H5FD_silo_t *file, int blidx)
     600           |               ^~~~~~~~~~~~~~~
     601     H5FDsilo.c: In function 'file_read_block':
  >> 602     H5FDsilo.c:259:1: error: expected ';' before '}' token
     603       259 | }
     604           | ^
     605     H5FDsilo.c:964:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     606       964 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_READERROR, "file_read_block failed", -1, -1)
     607           |         ^~~~~~~~~~~~~~~
  >> 608     H5FDsilo.c:980:15: error: invalid storage class for function 'remove_block_by_index'
     609       980 | static herr_t remove_block_by_index(H5FD_silo_t *file, int blidx)
     610           |               ^~~~~~~~~~~~~~~~~~~~~
     611     H5FDsilo.c:980:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     612       980 | static herr_t remove_block_by_index(H5FD_silo_t *file, int blidx)
     613           | ^~~~~~
  >> 614     H5FDsilo.c:1009:15: error: invalid storage class for function 'insert_block_by_index'
     615      1009 | static herr_t insert_block_by_index(H5FD_silo_t *file, int blidx)
     616           |               ^~~~~~~~~~~~~~~~~~~~~
  >> 617     H5FDsilo.c:1031:12: error: invalid storage class for function 'alloc_block_by_id'
     618      1031 | static int alloc_block_by_id(H5FD_silo_t *file, hsize_t id)
     619           |            ^~~~~~~~~~~~~~~~~
  >> 620     H5FDsilo.c:1066:15: error: invalid storage class for function 'free_block_by_index'
     621      1066 | static herr_t free_block_by_index(H5FD_silo_t *file, int blidx)
     622           |               ^~~~~~~~~~~~~~~~~~~
     623     H5FDsilo.c: In function 'H5Pset_fapl_silo':
  >> 624     H5FDsilo.c:259:1: error: expected ';' before '}' token
     625       259 | }
     626           | ^
     627     H5FDsilo.c:1174:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     628      1174 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_BADTYPE, "not a file access property list", -1, -1)
     629           |         ^~~~~~~~~~~~~~~
  >> 630     H5FDsilo.c:259:1: error: expected ';' before '}' token
     631       259 | }
     632           | ^
     633     H5FDsilo.c:1177:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     634      1177 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTINSERT, "can't insert " SILO_BLKSZ_PROPNAME, -1, -1)
     635           |         ^~~~~~~~~~~~~~~
  >> 636     H5FDsilo.c:259:1: error: expected ';' before '}' token
     637       259 | }
     638           | ^
     639     H5FDsilo.c:1179:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     640      1179 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTINSERT, "can't insert " SILO_BLKCNT_PROPNAME, -1, -1)
     641           |         ^~~~~~~~~~~~~~~
  >> 642     H5FDsilo.c:259:1: error: expected ';' before '}' token
     643       259 | }
     644           | ^
     645     H5FDsilo.c:1181:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     646      1181 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTINSERT, "can't insert " SILO_LOGSTS_PROPNAME, -1, -1)
     647           |         ^~~~~~~~~~~~~~~
  >> 648     H5FDsilo.c:259:1: error: expected ';' before '}' token
     649       259 | }
     650           | ^
     651     H5FDsilo.c:1183:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     652      1183 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTINSERT, "can't insert " SILO_USEDIR_PROPNAME, -1, -1)
     653           |         ^~~~~~~~~~~~~~~
  >> 654     H5FDsilo.c:259:1: error: expected ';' before '}' token
     655       259 | }
     656           | ^
     657     H5FDsilo.c:1186:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     658      1186 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTSET, "can't set " SILO_BLKSZ_PROPNAME, -1, -1)
     659           |         ^~~~~~~~~~~~~~~
  >> 660     H5FDsilo.c:259:1: error: expected ';' before '}' token
     661       259 | }
     662           | ^
     663     H5FDsilo.c:1188:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     664      1188 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTSET, "can't set " SILO_BLKCNT_PROPNAME, -1, -1)
     665           |         ^~~~~~~~~~~~~~~
  >> 666     H5FDsilo.c:259:1: error: expected ';' before '}' token
     667       259 | }
     668           | ^
     669     H5FDsilo.c:1190:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     670      1190 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTSET, "can't set " SILO_LOGSTS_PROPNAME, -1, -1)
     671           |         ^~~~~~~~~~~~~~~
  >> 672     H5FDsilo.c:259:1: error: expected ';' before '}' token
     673       259 | }
     674           | ^
     675     H5FDsilo.c:1192:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     676      1192 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTSET, "can't set " SILO_USEDIR_PROPNAME, -1, -1)
     677           |         ^~~~~~~~~~~~~~~
     678     H5FDsilo.c: In function 'H5Pset_silo_block_size_and_count':
  >> 679     H5FDsilo.c:259:1: error: expected ';' before '}' token
     680       259 | }
     681           | ^
     682     H5FDsilo.c:1207:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     683      1207 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_BADTYPE, "not a file access property list", -1, -1)
     684           |         ^~~~~~~~~~~~~~~
  >> 685     H5FDsilo.c:259:1: error: expected ';' before '}' token
     686       259 | }
     687           | ^
     688     H5FDsilo.c:1209:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     689      1209 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTSET, "can't set silo_block_size", -1, -1)
     690           |         ^~~~~~~~~~~~~~~
  >> 691     H5FDsilo.c:259:1: error: expected ';' before '}' token
     692       259 | }
     693           | ^
     694     H5FDsilo.c:1211:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     695      1211 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTSET, "can't set silo_block_count", -1, -1)
     696           |         ^~~~~~~~~~~~~~~
     697     H5FDsilo.c: In function 'H5Pset_silo_log_stats':
  >> 698     H5FDsilo.c:259:1: error: expected ';' before '}' token
     699       259 | }
     700           | ^
     701     H5FDsilo.c:1226:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     702      1226 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_BADTYPE, "not a file access property list", -1, -1)
     703           |         ^~~~~~~~~~~~~~~
  >> 704     H5FDsilo.c:259:1: error: expected ';' before '}' token
     705       259 | }
     706           | ^
     707     H5FDsilo.c:1228:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     708      1228 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTSET, "can't set silo_log_stats", -1, -1)
     709           |         ^~~~~~~~~~~~~~~
     710     H5FDsilo.c: In function 'H5Pset_silo_use_direct':
  >> 711     H5FDsilo.c:259:1: error: expected ';' before '}' token
     712       259 | }
     713           | ^
     714     H5FDsilo.c:1243:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     715      1243 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_BADTYPE, "not a file access property list", -1, -1)
     716           |         ^~~~~~~~~~~~~~~
  >> 717     H5FDsilo.c:259:1: error: expected ';' before '}' token
     718       259 | }
     719           | ^
     720     H5FDsilo.c:1245:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     721      1245 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTSET, "can't set " SILO_USEDIR_PROPNAME, -1, -1)
     722           |         ^~~~~~~~~~~~~~~
  >> 723     H5FDsilo.c:1268:1: error: invalid storage class for function 'H5FD_silo_sb_size'
     724      1268 | H5FD_silo_sb_size(H5FD_t *_file)
     725           | ^~~~~~~~~~~~~~~~~
     726     H5FDsilo.c:1267:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     727      1267 | static hsize_t
     728           | ^~~~~~
  >> 729     H5FDsilo.c:1294:1: error: invalid storage class for function 'H5FD_silo_sb_encode'
     730      1294 | H5FD_silo_sb_encode(H5FD_t *_file, char *name/*out*/,
     731           | ^~~~~~~~~~~~~~~~~~~
     732     H5FDsilo.c: In function 'H5FD_silo_sb_encode':
  >> 733     H5FDsilo.c:1314:5: error: expected ';' before 'return'
     734      1314 |     return 0;
     735           |     ^~~~~~
     736     H5FDsilo.c: In function 'H5Pset_silo_use_direct':
  >> 737     H5FDsilo.c:1328:1: error: invalid storage class for function 'H5FD_silo_sb_decode'
     738      1328 | H5FD_silo_sb_decode(H5FD_t *_file, const char *name, const unsigned char *buf)
     739           | ^~~~~~~~~~~~~~~~~~~
     740     H5FDsilo.c: In function 'H5FD_silo_sb_decode':
  >> 741     H5FDsilo.c:1342:5: error: expected ';' before 'buf'
     742      1342 |     buf += 8;
     743           |     ^~~
  >> 744     H5FDsilo.c:1348:5: error: expected ';' before 'ap'
     745      1348 |     ap = (hsize_t*)x;
     746           |     ^~
     747     H5FDsilo.c: In function 'H5Pset_silo_use_direct':
  >> 748     H5FDsilo.c:1388:1: error: invalid storage class for function 'H5FD_silo_open'
     749      1388 | H5FD_silo_open( const char *name, unsigned flags, hid_t fapl_id,
     750           | ^~~~~~~~~~~~~~
     751     H5FDsilo.c: In function 'H5FD_silo_open':
  >> 752     H5FDsilo.c:259:1: error: expected ';' before '}' token
     753       259 | }
     754           | ^
     755     H5FDsilo.c:1412:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     756      1412 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_ARGS, H5E_BADVALUE, "invalid file name", NULL, -1)
     757           |         ^~~~~~~~~~~~~~~
  >> 758     H5FDsilo.c:259:1: error: expected ';' before '}' token
     759       259 | }
     760           | ^
     761     H5FDsilo.c:1414:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     762      1414 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_ARGS, H5E_BADRANGE, "bogus maxaddr", NULL, -1)
     763           |         ^~~~~~~~~~~~~~~
  >> 764     H5FDsilo.c:259:1: error: expected ';' before '}' token
     765       259 | }
     766           | ^
     767     H5FDsilo.c:1416:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     768      1416 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_ARGS, H5E_OVERFLOW, "maxaddr too large", NULL, -1)
     769           |         ^~~~~~~~~~~~~~~
  >> 770     H5FDsilo.c:259:1: error: expected ';' before '}' token
     771       259 | }
     772           | ^
     773     H5FDsilo.c:1420:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     774      1420 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTGET, "can't get " SILO_BLKSZ_PROPNAME, 0, -1)
     775           |         ^~~~~~~~~~~~~~~
  >> 776     H5FDsilo.c:259:1: error: expected ';' before '}' token
     777       259 | }
     778           | ^
     779     H5FDsilo.c:1423:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     780      1423 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTGET, "can't get " SILO_BLKCNT_PROPNAME, 0, -1)
     781           |         ^~~~~~~~~~~~~~~
  >> 782     H5FDsilo.c:259:1: error: expected ';' before '}' token
     783       259 | }
     784           | ^
     785     H5FDsilo.c:1425:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     786      1425 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTGET, "silo_block_count<1", 0, -1)
     787           |         ^~~~~~~~~~~~~~~
  >> 788     H5FDsilo.c:259:1: error: expected ';' before '}' token
     789       259 | }
     790           | ^
     791     H5FDsilo.c:1428:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     792      1428 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTGET, "can't get " SILO_LOGSTS_PROPNAME, 0, -1)
     793           |         ^~~~~~~~~~~~~~~
  >> 794     H5FDsilo.c:259:1: error: expected ';' before '}' token
     795       259 | }
     796           | ^
     797     H5FDsilo.c:1430:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     798      1430 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_PLIST, H5E_CANTGET, "can't get " SILO_USEDIR_PROPNAME, 0, -1)
     799           |         ^~~~~~~~~~~~~~~
  >> 800     H5FDsilo.c:259:1: error: expected ';' before '}' token
     801       259 | }
     802           | ^
     803     H5FDsilo.c:1448:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     804      1448 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_IO, H5E_CANTOPENFILE, "HDopen failed", NULL, errno)
     805           |         ^~~~~~~~~~~~~~~
  >> 806     H5FDsilo.c:259:1: error: expected ';' before '}' token
     807       259 | }
     808           | ^
     809     H5FDsilo.c:1453:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     810      1453 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_FILE, H5E_BADFILE, "HDfstat failed", NULL, errno)
     811           |         ^~~~~~~~~~~~~~~
  >> 812     H5FDsilo.c:259:1: error: expected ';' before '}' token
     813       259 | }
     814           | ^
     815     H5FDsilo.c:1463:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     816      1463 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_RESOURCE, H5E_NOSPACE, "calloc failed", NULL, errno)
     817           |         ^~~~~~~~~~~~~~~
  >> 818     H5FDsilo.c:259:1: error: expected ';' before '}' token
     819       259 | }
     820           | ^
     821     H5FDsilo.c:1469:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     822      1469 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_RESOURCE, H5E_NOSPACE, "calloc failed", NULL, errno)
     823           |         ^~~~~~~~~~~~~~~
  >> 824     H5FDsilo.c:259:1: error: expected ';' before '}' token
     825       259 | }
     826           | ^
     827     H5FDsilo.c:1489:13: note: in expansion of macro 'H5E_PUSH_HELPER'
     828      1489 |             H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_RESOURCE, H5E_NOSPACE, "malloc failed", NULL, errno)
     829           |             ^~~~~~~~~~~~~~~
  >> 830     H5FDsilo.c:1536:1: error: invalid storage class for function 'H5FD_silo_close'
     831      1536 | H5FD_silo_close(H5FD_t *_file)
     832           | ^~~~~~~~~~~~~~~
     833     H5FDsilo.c: In function 'H5FD_silo_close':
  >> 834     H5FDsilo.c:259:1: error: expected ';' before '}' token
     835       259 | }
     836           | ^
     837     H5FDsilo.c:1572:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     838      1572 |         H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_IO, H5E_CLOSEERROR, "close failed", -1, errno)
     839           |         ^~~~~~~~~~~~~~~
  >> 840     H5FDsilo.c:1755:1: error: invalid storage class for function 'H5FD_silo_cmp'
     841      1755 | H5FD_silo_cmp(const H5FD_t *_f1, const H5FD_t *_f2)
     842           | ^~~~~~~~~~~~~
     843     H5FDsilo.c:1754:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     844      1754 | static int
     845           | ^~~~~~
  >> 846     H5FDsilo.c:1815:1: error: invalid storage class for function 'H5FD_silo_query'
     847      1815 | H5FD_silo_query(const H5FD_t *_f, unsigned long *flags /* out */)
     848           | ^~~~~~~~~~~~~~~
  >> 849     H5FDsilo.c:1856:1: error: invalid storage class for function 'H5FD_silo_get_eoa'
     850      1856 | H5FD_silo_get_eoa(const H5FD_t *_file, H5FD_mem_t /*unused*/ type)
     851           | ^~~~~~~~~~~~~~~~~
  >> 852     H5FDsilo.c:1892:1: error: invalid storage class for function 'H5FD_silo_set_eoa'
     853      1892 | H5FD_silo_set_eoa(H5FD_t *_file, H5FD_mem_t type, haddr_t addr)
     854           | ^~~~~~~~~~~~~~~~~
  >> 855     H5FDsilo.c:1929:1: error: invalid storage class for function 'H5FD_silo_get_eof'
     856      1929 | H5FD_silo_get_eof(const H5FD_t *_file)
     857           | ^~~~~~~~~~~~~~~~~
  >> 858     H5FDsilo.c:1951:1: error: invalid storage class for function 'H5FD_silo_get_handle'
     859      1951 | H5FD_silo_get_handle(H5FD_t *_file, hid_t fapl, void** file_handle)
     860           | ^~~~~~~~~~~~~~~~~~~~
  >> 861     H5FDsilo.c:1993:1: error: invalid storage class for function 'H5FD_silo_read'
     862      1993 | H5FD_silo_read(H5FD_t *_file, H5FD_mem_t type, hid_t dxpl_id, haddr_t addr, size_t size,
     863           | ^~~~~~~~~~~~~~
     864     H5FDsilo.c: In function 'H5FD_silo_read':
  >> 865     H5FDsilo.c:259:1: error: expected ';' before '}' token
     866       259 | }
     867           | ^
     868     H5FDsilo.c:2016:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     869      2016 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW, "file address overflowed", -1, -1)
     870           |         ^~~~~~~~~~~~~~~
  >> 871     H5FDsilo.c:259:1: error: expected ';' before '}' token
     872       259 | }
     873           | ^
     874     H5FDsilo.c:2018:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     875      2018 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW, "file address overflowed", -1, -1)
     876           |         ^~~~~~~~~~~~~~~
  >> 877     H5FDsilo.c:259:1: error: expected ';' before '}' token
     878       259 | }
     879           | ^
     880     H5FDsilo.c:2020:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     881      2020 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW, "file address overflowed", -1, -1)
     882           |         ^~~~~~~~~~~~~~~
  >> 883     H5FDsilo.c:2124:1: error: invalid storage class for function 'H5FD_silo_write'
     884      2124 | H5FD_silo_write(H5FD_t *_file, H5FD_mem_t type, hid_t dxpl_id, haddr_t addr,
     885           | ^~~~~~~~~~~~~~~
     886     H5FDsilo.c: In function 'H5FD_silo_write':
  >> 887     H5FDsilo.c:259:1: error: expected ';' before '}' token
     888       259 | }
     889           | ^
     890     H5FDsilo.c:2147:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     891      2147 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW, "file address overflowed", -1, -1)
     892           |         ^~~~~~~~~~~~~~~
  >> 893     H5FDsilo.c:259:1: error: expected ';' before '}' token
     894       259 | }
     895           | ^
     896     H5FDsilo.c:2149:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     897      2149 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW, "file address overflowed", -1, -1)
     898           |         ^~~~~~~~~~~~~~~
  >> 899     H5FDsilo.c:259:1: error: expected ';' before '}' token
     900       259 | }
     901           | ^
     902     H5FDsilo.c:2151:9: note: in expansion of macro 'H5E_PUSH_HELPER'
     903      2151 |         H5E_PUSH_HELPER (func, H5E_ERR_CLS, H5E_IO, H5E_OVERFLOW, "file address overflowed", -1, -1)
     904           |         ^~~~~~~~~~~~~~~
  >> 905     H5FDsilo.c:2249:1: error: invalid storage class for function 'H5FD_silo_truncate'
     906      2249 | H5FD_silo_truncate(H5FD_t *_file, hid_t dxpl_id, hbool_t closing)
     907           | ^~~~~~~~~~~~~~~~~~
     908     H5FDsilo.c: In function 'H5FD_silo_truncate':
  >> 909     H5FDsilo.c:259:1: error: expected ';' before '}' token
     910       259 | }
     911           | ^
     912     H5FDsilo.c:2291:13: note: in expansion of macro 'H5E_PUSH_HELPER'
     913      2291 |             H5E_PUSH_HELPER(func, H5E_ERR_CLS, H5E_IO, H5E_SEEKERROR, "HDftruncate failed", -1, errno)
     914           |             ^~~~~~~~~~~~~~~
  >> 915     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     916      2303 | } /* end H5FD_silo_truncate() */
     917           | ^
     918     H5FDsilo.c: In function 'H5FD_silo_write':
     919     H5FDsilo.c:2248:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     920      2248 | static herr_t
     921           | ^~~~~~
  >> 922     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     923      2303 | } /* end H5FD_silo_truncate() */
     924           | ^
  >> 925     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 926     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     927     H5FDsilo.c: In function 'H5FD_silo_read':
     928     H5FDsilo.c:2123:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     929      2123 | static herr_t
     930           | ^~~~~~
  >> 931     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     932      2303 | } /* end H5FD_silo_truncate() */
     933           | ^
  >> 934     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 935     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     936     H5FDsilo.c: In function 'H5FD_silo_close':
  >> 937     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     938     H5FDsilo.c: In function 'H5FD_silo_open':
     939     H5FDsilo.c:1535:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     940      1535 | static herr_t
     941           | ^~~~~~
  >> 942     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     943      2303 | } /* end H5FD_silo_truncate() */
     944           | ^
  >> 945     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 946     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 947     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 948     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 949     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 950     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 951     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 952     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 953     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 954     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 955     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 956     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     957     H5FDsilo.c: In function 'H5Pset_silo_use_direct':
  >> 958     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 959     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     960     H5FDsilo.c: In function 'H5Pset_silo_log_stats':
     961     H5FDsilo.c:1233:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     962      1233 | herr_t
     963           | ^~~~~~
  >> 964     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     965      2303 | } /* end H5FD_silo_truncate() */
     966           | ^
  >> 967     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     968     H5FDsilo.c: In function 'H5Pset_silo_block_size_and_count':
     969     H5FDsilo.c:1216:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     970      1216 | herr_t
     971           | ^~~~~~
  >> 972     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     973      2303 | } /* end H5FD_silo_truncate() */
     974           | ^
  >> 975     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 976     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     977     H5FDsilo.c: In function 'H5Pset_fapl_silo':
     978     H5FDsilo.c:1197:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     979      1197 | herr_t
     980           | ^~~~~~
  >> 981     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     982      2303 | } /* end H5FD_silo_truncate() */
     983           | ^
  >> 984     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 985     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 986     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 987     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 988     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 989     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 990     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 991     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     992     H5FDsilo.c: In function 'file_read_block':
  >> 993     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     994     H5FDsilo.c: In function 'file_write_block':
     995     H5FDsilo.c:952:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     996       952 | static herr_t file_read_block(H5FD_silo_t *file, int blidx)
     997           | ^~~~~~
  >> 998     H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     999      2303 | } /* end H5FD_silo_truncate() */
     1000          | ^
     1001    H5FDsilo.c: In function 'file_read':
     1002    H5FDsilo.c:910:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     1003      910 | static herr_t file_write_block(H5FD_silo_t *file, int blidx)
     1004          | ^~~~~~
  >> 1005    H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     1006     2303 | } /* end H5FD_silo_truncate() */
     1007          | ^
  >> 1008    H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 1009    H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 1010    H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     1011    H5FDsilo.c: In function 'file_write':
     1012    H5FDsilo.c:848:1: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
     1013      848 | static herr_t file_read(H5FD_silo_t *file, haddr_t addr, size_t size, void *buf)
     1014          | ^~~~~~
  >> 1015    H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     1016     2303 | } /* end H5FD_silo_truncate() */
     1017          | ^
  >> 1018    H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 1019    H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
  >> 1020    H5FDsilo.c:2303:1: error: expected declaration or statement at end of input
     1021    H5FDsilo.c: At top level:
     1022    H5FDsilo.c:479:16: warning: 'H5FD_silo_sb_size' used but never defined
     1023      479 | static hsize_t H5FD_silo_sb_size(H5FD_t *file);
     1024          |                ^~~~~~~~~~~~~~~~~
     1025    H5FDsilo.c:480:15: warning: 'H5FD_silo_sb_encode' used but never defined
     1026      480 | static herr_t H5FD_silo_sb_encode(H5FD_t *file, char *name/*out*/,

     ...

     1058    H5FDsilo.c:495:15: warning: 'H5FD_silo_write' used but never defined
     1059      495 | static herr_t H5FD_silo_write(H5FD_t *lf, H5FD_mem_t type, hid_t fapl_id, haddr_t addr,
     1060          |               ^~~~~~~~~~~~~~~
     1061    H5FDsilo.c:497:15: warning: 'H5FD_silo_truncate' used but never defined
     1062      497 | static herr_t H5FD_silo_truncate(H5FD_t *_file, hid_t dxpl_id, hbool_t closing);
     1063          |               ^~~~~~~~~~~~~~~~~~
  >> 1064    make[4]: *** [Makefile:499: H5FDsilo.lo] Error 1
     1065    make[4]: *** Waiting for unfinished jobs....
     1066    silo_hdf5.c: In function 'db_hdf5_process_file_options':
     1067    silo_hdf5.c:4667:2: warning: #warning REMOVED WINDOWS SPECIFIC CHECK [-Wcpp]
     1068     4667 | #warning REMOVED WINDOWS SPECIFIC CHECK
     1069          |  ^~~~~~~
     1070    silo_hdf5.c:4799:2: warning: #warning REMOVED WINDOWS SPECIFIC CHECK [-Wcpp]

     ...

     1079          |                                              %ld
     1080    In file included from /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/hdf5-1.12.1-n5vn6kguza6zyjvxyt
             77z2ehzl44yfp5/include/H5public.h:32,
     1081                     from /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/hdf5-1.12.1-n5vn6kguza6zyjvxyt
             77z2ehzl44yfp5/include/hdf5.h:22,
     1082                     from silo_hdf5_private.h:71,
     1083                     from silo_hdf5.c:72:
     1084    silo_hdf5.c: In function 'db_hdf5_SortObjectsByOffset':
  >> 1085    /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/hdf5-1.12.1-n5vn6kguza6zyjvxyt77z2ehzl44yfp5/include
             /H5version.h:746:23: error: too few arguments to function 'H5Oget_info3'
     1086      746 |   #define H5Oget_info H5Oget_info3
     1087          |                       ^~~~~~~~~~~~
     1088    silo_hdf5.c:15763:18: note: in expansion of macro 'H5Oget_info'
     1089    15763 |                  H5Oget_info(oid, &oinfo)<0 ||
     1090          |                  ^~~~~~~~~~~
     1091    In file included from /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/hdf5-1.12.1-n5vn6kguza6zyjvxyt
             77z2ehzl44yfp5/include/H5Apublic.h:22,
     1092                     from /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/hdf5-1.12.1-n5vn6kguza6zyjvxyt
             77z2ehzl44yfp5/include/hdf5.h:23,
     1093                     from silo_hdf5_private.h:71,
     1094                     from silo_hdf5.c:72:
     1095    /home2/cessenat/Softs/spack/opt/spack/linux-ubuntu20.04-zen2/gcc-9.3.0/hdf5-1.12.1-n5vn6kguza6zyjvxyt77z2ehzl44yfp5/include
             /H5Opublic.h:497:15: note: declared here
     1096      497 | H5_DLL herr_t H5Oget_info3(hid_t loc_id, H5O_info2_t *oinfo, unsigned fields);
     1097          |               ^~~~~~~~~~~~
  >> 1098    silo_hdf5.c:15767:38: error: 'H5O_info2_t' {aka 'struct H5O_info2_t'} has no member named 'addr'
     1099    15767 |                 iop[i].offset = oinfo.addr;
     1100          |                                      ^
  >> 1101    make[4]: *** [Makefile:499: silo_hdf5.lo] Error 1
     1102    make[4]: Leaving directory '/tmp/cessenat/spack-stage/spack-stage-silo-4.10.2-vlgacj4rmtixtudik6myfm2ho7qvbuz2/spack-src/sr
             c/hdf5_drv'
  >> 1103    make[3]: *** [Makefile:685: all-recursive] Error 1
     1104    make[3]: Leaving directory '/tmp/cessenat/spack-stage/spack-stage-silo-4.10.2-vlgacj4rmtixtudik6myfm2ho7qvbuz2/spack-src/sr
             c'
  >> 1105    make[2]: *** [Makefile:557: all] Error 2
     1106    make[2]: Leaving directory '/tmp/cessenat/spack-stage/spack-stage-silo-4.10.2-vlgacj4rmtixtudik6myfm2ho7qvbuz2/spack-src/sr
             c'
  >> 1107    make[1]: *** [Makefile:540: all-recursive] Error 1
     1108    make[1]: Leaving directory '/tmp/cessenat/spack-stage/spack-stage-silo-4.10.2-vlgacj4rmtixtudik6myfm2ho7qvbuz2/spack-src'
  >> 1109    make: *** [Makefile:472: all] Error 2

See build log for details:
  /tmp/cessenat/spack-stage/spack-stage-silo-4.10.2-vlgacj4rmtixtudik6myfm2ho7qvbuz2/spack-build-out.txt

Information on your system

$ spack debug report

• Spack: 0.17.0-852-1ea4497802
• Python: 3.8.10
• Platform: linux-ubuntu20.04-zen2
• Concretizer: original

$ uname -a
Linux jliana 5.11.0-44-generic #48~20.04.2-Ubuntu SMP Tue Dec 14 15:36:44 UTC 2021 x86_64 x86_64 x86_64 GNU/Linux
Ubuntu 20.04 gcc 9.3.0

Additional information

spack-build-env.txt
spack-build-out.txt

General information

• I have run spack debug report and reported the version of Spack/Python/Platform
• I have run spack maintainers <name-of-the-package> and @mentioned any maintainers
• I have uploaded the build log and environment files
• I have searched the issues of this repo and believe this is not a duplicate

[cessenat]

One more thing, with clingo and no ~/.spack/packages.yaml concretization picks hdf5@1.10.7 which works, but I expected hdf5@1.10.8.

[lrknox]

Commit #27613 included a patch for these errors in silo 4.11 with hdf5 1.10.8 and 1.12.1 (and above). That commit was merged to develop 29 days ago which I think works out to mid December. I checked Spack v0.17.1; the patch was not included in that version.

Commit #27613 also include a preferred version 1.10.8 for HDF5 which was later removed. A preferred version 1.12.1 has since been added to the HDF5 package. The patch should also be applied to silo 4.11 with HDF5 1.12.1.

I'll try building silo with Spack develop. I expect it to build without error, but will report result.
spack spec silo does pick hdf5@1.10.7 because the preferred silo version is 4.10.2. spack spec silo@4.11 picks hdf5@1.12.1, but should also build with hdf5@1.10.8.

Both "spack install silo@4.11" and "spack install silo@4.11 ^hdf5@1.10.8" installed successfully with today's spack develop on a Linux 3.10.0-1160.24.1.el7.x86_64 #1 SMP machine.

I'm confused that the reported spack version doesn't have hdf5 1.10.7 preferred, since the change to hdf5 1.10.8 preferred and the silo patch were both in commit #27613, and the commit removing preferred for hdf5 and the subsequent one adding it for 1.12.1 came afterwards,

[sethrj]

@cessenat I had some issues with silo/hdf5 as well, fixed in #29132 . Can you try again and see if the issue is still here?

[cessenat]

@cessenat I had some issues with silo/hdf5 as well, fixed in #29132 . Can you try again and see if the issue is still here?

It is fine now with clingo :
spack install silo~mpi %gcc ^hdf5~mpi %gcc
=> hdf5-1.12.1 + silo-4.10.2
It uses 1.12.1 instead of 1.10.7 some time ago.
Spec indicates hdf5 api=v110 is concretized.

$ spack spec silo~mpi %gcc ^hdf5~mpi %gcc
silo@4.10.2%gcc@9.3.0+fortran+fpzip+hdf5+hzip~mpi+pic+shared~silex patches=7b5a1dc,952d3c9,eb2a3a0 arch=linux-ubuntu20.04-zen2
    ^hdf5@1.12.1%gcc@9.3.0~cxx~fortran~hl~ipo~java~mpi+shared~szip~threadsafe+tools api=v110 build_type=RelWithDebInfo patches=ee351eb arch=linux-ubuntu20.04-zen2

But with original concretizer, hdf5 api=default is concretized:

$ spack install silo~mpi %gcc ^hdf5~mpi %gcc
==> Warning: the original concretizer is currently being used.
	Upgrade to "clingo" at your earliest convenience. The original concretizer will be removed from Spack starting at v0.18.0
==> Error: An unsatisfiable variant constraint has been detected for spec:

    hdf5@1.12.1%gcc@9.3.0~cxx~fortran~hl~ipo~java~mpi+shared~szip~threadsafe+tools api=default build_type=RelWithDebInfo arch=linux-ubuntu20.04-zen2
        ^cmake@3.16.3%gcc@9.3.0~doc+ncurses+openssl+ownlibs~qt build_type=Release arch=linux-ubuntu20.04-zen2
        ^pkgconf@1.8.0%gcc@9.3.0 arch=linux-ubuntu20.04-zen2
        ^zlib@1.2.11%gcc@9.3.0+optimize+pic+shared arch=linux-ubuntu20.04-zen2


while trying to concretize the partial spec:

    silo@4.10.2%gcc@9.3.0+fortran+fpzip+hdf5+hzip~mpi+pic+shared~silex arch=linux-ubuntu20.04-zen2
        ^autoconf@2.69%gcc@9.3.0 arch=linux-ubuntu20.04-zen2
            ^m4@1.4.19%gcc@9.3.0+sigsegv arch=linux-ubuntu20.04-zen2
                ^libsigsegv
            ^perl@5.30.0%gcc@9.3.0~cpanm+shared+threads arch=linux-ubuntu20.04-zen2
        ^automake@1.16.5%gcc@9.3.0 arch=linux-ubuntu20.04-zen2
        ^hdf5@1.12.1%gcc@9.3.0~cxx~fortran~hl~ipo~java~mpi+shared~szip~threadsafe+tools api=default build_type=RelWithDebInfo arch=linux-ubuntu20.04-zen2
            ^cmake@3.16.3%gcc@9.3.0~doc+ncurses+openssl+ownlibs~qt build_type=Release arch=linux-ubuntu20.04-zen2
            ^pkgconf@1.8.0%gcc@9.3.0 arch=linux-ubuntu20.04-zen2
            ^zlib@1.2.11%gcc@9.3.0+optimize+pic+shared arch=linux-ubuntu20.04-zen2
        ^libtool@2.4.6%gcc@9.3.0 arch=linux-ubuntu20.04-zen2
        ^readline@8.1%gcc@9.3.0 arch=linux-ubuntu20.04-zen2
            ^ncurses@6.2%gcc@9.3.0~symlinks+termlib abi=none arch=linux-ubuntu20.04-zen2


silo requires hdf5 variant api=v110, but spec asked for api=default

Final test, when requesting silo 4.11 it is OK both for clingo and original concretizers, with hdf5 api=default:

spack spec silo@4.11~mpi %gcc ^hdf5~mpi %gcc
==> Warning: the original concretizer is currently being used.
silo@4.11%gcc@9.3.0+fortran+fpzip+hdf5+hzip~mpi+pic+shared~silex patches=eb2a3a0 arch=linux-ubuntu20.04-zen2
    ^hdf5@1.12.1%gcc@9.3.0~cxx~fortran~hl~ipo~java~mpi+shared~szip~threadsafe+tools api=default build_type=RelWithDebInfo patches=ee351eb arch=linux-ubuntu20.04-zen2

$ spack debug report

• Spack: 0.17.0-1654-8c508b530b
• Python: 3.8.10
• Platform: linux-ubuntu20.04-zen2
• Concretizer: original

Hope it helps @sethrj

[sethrj]

Sounds like my PR fixed the error you were seeing then. Glad to hear it!