-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvm+gold
with external binutils
build failure because of missing plugin-api.h
header
#29350
Comments
Note, I can build when using the command |
I can confirm the same issue also happens with |
Summoning @scheibelp |
I got here after googling a different problem. I got the same error "plugin-api.h: No such file or directory" while building llvm tests (make check-all). The solution to my problem was installing the missing binutils-dev. Maybe this helps here too? |
For what is worth, I got the same error when building llvm 8.0.0, so this isn't specific to 13+ |
I don't think we're gonna fix this in Spack. It's an issue in LLVM, they should check for the header s.t. it's an error caught during cmake/configure. It happens when binutils is external and only runtime components are installed (e.g. binutils-dev is missing). If you're using externals you're telling Spack that it's a drop-in replacement for the Spack package. |
llvm+gold
with external binutils
build failure because of missing plugin-api.h
header
That's indeed my case, but perhaps there should be a spack variant of binutils with only the runtime, to match what distro do? |
This issue happens for me when Spack detects binutils as an external package itself (with |
…ing llvm with gold
…ing llvm with gold (spack#37245)
llvm needs +headers for plugin-api.h which most distros don't install. Fixes spack#29350. Also check for installed gold linker and set +gold/~gold
- llvm needs binutils+headers for plugin-api.h which most distros don't install and therefore make spack external find binutils detect binutils~headers. This forces spack to build binutils even when binutils have been imported from the system. This fixes the build of llvm in spack#29350. - Also check for installed gold linker and set +gold/~gold
Fixes spack#29350: - binutils: Make spack external find binutils set ~headers to fix build of llvm Changes: Add initial def determine_variants(): - llvm needs binutils+headers for plugin-api.h which most distros don't install and therefore make spack external find binutils detect binutils~headers. This forces spack to build binutils for llvm when binutils have been imported from the system. This fixes the build of llvm in spack#29350. - Also check for installed gold linker and set +gold/~gold
…e if we install binutils-dev?
…e if we install binutils+headers?
Steps to reproduce
Error message
Information on your system
General information
spack debug report
and reported the version of Spack/Python/PlatformThe text was updated successfully, but these errors were encountered: