-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed libxcb deps and added patch to remove pthread-stubs dep #1042
Conversation
This should also help to build |
something similar is done in #820, but that PR is inactive for about a month. |
I had similar problem. I tried to use #820 and found some problems. I would like to use spack for building different flawors of ParaView: does it make sense to try to contribute here or is better to just use my private copy of packages? Thanks |
@luigi-calori you can't contribute to an open PR unless github user grants you write access to his fork. I think it is always better to fix things upstream in Spack. My guess is that this PR will be merged faster than #820 so perhaps one could wait a bit (with a hope that PRs start merging again soon 😄) and then open a follow up PR with the changes you have. |
Thanks. I' ll try to work on other stuff... Nevertheless, I' m quite worried about the lack of merging: If the rate between PR submission / PR merging keeps increasing, contributing would be harder and more effort should be dedicated to merging. |
@lee218llnl @luigi-calori can you see if the current |
@tgamblin The latest develop branch worked for me. I am OK with deleting/closing this PR, but we may want to wait for confirmation from @luigi-calori |
@luigi-calori: I'll close this if the latest |
@luigi-calori: please reopen if this issue regresses. |
These changes were needed to build on a TOSS3 (RHEL7) based system.