Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'make test' detection when LANG is not in English #10499

Merged
merged 2 commits into from
Feb 27, 2019

Conversation

adamjstewart
Copy link
Member

Fixes #10487.

@weidendo can you test this?

We need to be careful here, as config.yaml provides a build_language setting that we don't want to overwrite.

@adamjstewart adamjstewart added tests General test capability(ies) makefile labels Feb 1, 2019
@weidendo
Copy link

weidendo commented Feb 4, 2019

Thanks, works as expected here!
Excerpt with a Valgrind.spec which does trigger the default behaviour for a test with Autotools, ie. checking for target "test", then "check" (which does exist):

$ echo $LANG
de_DE.UTF-8
$ spack install -v --use-cache --test root valgrind~boost
...
==> RUN-TESTS: build-time tests [check]
==> 'make' '-j24' '-n' 'test'
==> Target 'test' not found in Makefile
==> 'make' '-j24' '-n' 'check'
==> 'make' '-j24' 'check'
...

@scheibelp scheibelp merged commit a25edb5 into spack:develop Feb 27, 2019
@scheibelp
Copy link
Member

Thanks!

@adamjstewart adamjstewart deleted the fixes/make-lang branch February 27, 2019 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
makefile tests General test capability(ies)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants