Add additional common C++ and Fortran header file extensions #11600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Less common, but still: C++: |
|
I don't know exactly what version I had checked out! I did a 'git pull'
and now things appear to be working!
Thanks,
Jim
On Fri, 31 May 2019, Adam J. Stewart wrote:
See #11588 ***@***.***)
Can anyone think of any other common header file extensions?
You can view, comment on, or merge this pull request online at:
#11600
-- Commit Summary --
* Add additional common C++ and Fortran header file extensions
-- File Changes --
M lib/spack/llnl/util/filesystem.py (9)
-- Patch Links --
https://github.com/spack/spack/pull/11600.patch
https://github.com/spack/spack/pull/11600.diff
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#11600
James E. Prewett Jim@Prewett.org download@hpc.unm.edu
Systems Team Leader LoGS: http://www.hpc.unm.edu/~download/LoGS/
Designated Security Officer OpenPGP key: pub 1024D/31816D93
HPC Systems Engineer III UNM HPC 505.277.8210
|
alalazo
approved these changes
Jun 4, 2019
| suffixes = ['h', 'hpp', 'mod'] | ||
| suffixes = [ | ||
| # C | ||
| 'h', |
There was a problem hiding this comment.
OCD: technically .h is also common practice in C++ 🙂
chuckatkins
reviewed
Jun 4, 2019
tgamblin
approved these changes
Jun 6, 2019
|
Sorry to be nickle-and-diming this one to death, but now it's been mentioned, some communities use |
carsonwoods
pushed a commit
to carsonwoods/spack
that referenced
this pull request
Jun 27, 2019
…1600) * Add additional common C++ and Fortran header file extensions * Add .hxx extension * Add .txx and .tcc extensions * Add .icc extension
dev-zero
pushed a commit
to dev-zero/spack
that referenced
this pull request
Aug 13, 2019
…1600) * Add additional common C++ and Fortran header file extensions * Add .hxx extension * Add .txx and .tcc extensions * Add .icc extension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #11588 (@downloadico)
This is a continuation of #10798 (@michaelkuhn)
Can anyone think of any other common header file extensions?