bugfix: lua-luafilesystem package should use stage.source_path

[tgamblin]

Fixes #11645.
@odoublewen

After #11528, we use $stage_dir/src as the path for all expanded tarballs, so that the expanded path is known in advance. This helps client code that needs to know the checked out source path before fetching and expanding the source.

Some builds seem to assume they know stage.source_path and construct it themselves. e.g, lua-luafilesystem was doing this:

fmt = os.path.join(
    self.stage.path,
    'luafilesystem-{version.underscored}',
    'rockspecs',
    'luafilesystem-{semver.dotted}-{tweak_level}.rockspec'
)

It assumes the name of the directory under stage is 'luafilesystem-{version.underscored}'. Code like this should use stage.source_path instead of joining stage.path with an assumed name.

Here is the fix:

fmt = os.path.join(
    self.stage.source_path,
    'rockspecs',
    'luafilesystem-{semver.dotted}-{tweak_level}.rockspec'
)

[tgamblin]

@odoublewen: does this work for you?

[odoublewen]

Works for me. Tried to do a quick survey of package.py files to see where else this construct might be lurking. Perhaps these lines in lmod/package.py also need to be updated? I'll test it....

    def setup_environment(self, spack_env, run_env):
        stage_lua_path = join_path(
            self.stage.path, 'Lmod-{version}', 'src', '?.lua')

[odoublewen]

Well, the lmod package builds fine as it is...

[tgamblin]

I think it probably needs an update. Most of these as well:

$ git grep stage.path
packages/aspera-cli/package.py:        runfile = glob(join_path(self.stage.path, 'aspera-cli*.sh'))[0]
packages/bcl2fastq2/package.py:            with working_dir(self.stage.path):
packages/catalyst/package.py:        paraview_dir = os.path.join(self.stage.path,
packages/catalyst/package.py:            tty.msg("Generated catalyst source in %s" % self.stage.path)
packages/catalyst/package.py:                                                    self.stage.path))
packages/catalyst/package.py:        return os.path.join(self.stage.path, 'Catalyst-v' + str(self.version))
packages/charmpp/package.py:        make('-C', join_path(self.stage.path, 'charm/tests'),
packages/clhep/package.py:                    % (self.stage.path, self.spec.version))
packages/cuda/package.py:        runfile = glob(join_path(self.stage.path, 'cuda*_linux*'))[0]
packages/lmod/package.py:            self.stage.path, 'Lmod-{version}', 'src', '?.lua')
packages/nseg/package.py:                res_path = join_path(res.fetcher.stage.path, res.name)
packages/singularity/package.py:        return join_path(self.stage.path)