environments: activate/deactivate tests, support set -u
#11942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgamblin
force-pushed
the
features/more-sh-tests-for-environments
branch
2 times, most recently
from
0c1dea4
to
704b8ad
Compare
tgamblin
force-pushed
the
features/more-sh-tests-for-environments
branch
from
704b8ad
to
761befe
Compare
tgamblin
changed the title
set -uset -u
tgamblin
changed the title
set -uset -u
- [x] Add shell tests to ensure that `spack env activate`, `spack env deactivate`, and `despacktivate` continue to work. - [x] Also ensure that activate and deactivate both work with `set -u`
tgamblin
force-pushed
the
features/more-sh-tests-for-environments
branch
from
761befe
to
26feb74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #4048 I tried running
spack env activateanddespacktivateand noticed some problems. Turned out they were with my environment, but I added shell tests for this stuff anyway. This actually ended up catching a bug in the code output byspack env deactivate --sh-- it now works properly withset -u.Add shell tests to ensure that
spack env activate,spack env deactivate, anddespacktivatecontinue to work.Also ensure that activate and deactivate both work with
set -u