Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

luarocks: Use make command instead of install #12703

Merged
merged 1 commit into from
Sep 8, 2019
Merged

luarocks: Use make command instead of install #12703

merged 1 commit into from
Sep 8, 2019

Conversation

rdbisme
Copy link
Contributor

@rdbisme rdbisme commented Sep 4, 2019

This way luarocks does not attempt to pull stuff from the internet.

Fix #3909
Fix #7848

Ref: https://stackoverflow.com/a/43321646/1334711

This way luarocks does not attempt to pull stuff from the internet.

Fix #3909
Copy link
Member

@adamjstewart adamjstewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There aren't a ton of Lua packages in Spack at the moment, and the installation process is pretty simple, but someday we'll want to add a LuaPackage base class.

@adamjstewart adamjstewart merged commit ac7a177 into spack:develop Sep 8, 2019
tldahlgren pushed a commit to tldahlgren/spack that referenced this pull request Oct 11, 2019
This way luarocks does not attempt to pull stuff from the internet.

Fix spack#3909
jrmadsen pushed a commit to jrmadsen/spack that referenced this pull request Oct 30, 2019
This way luarocks does not attempt to pull stuff from the internet.

Fix spack#3909
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants