deprecate spack diy in favor of spack dev-build #13374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this fix #3642? That is, can I use |
|
@adamjstewart: yes |
tgamblin
requested changes
Oct 23, 2019
lib/spack/spack/cmd/diy.py
Outdated
| @@ -50,6 +50,7 @@ def setup_parser(subparser): | |||
|
|
|||
|
|
|||
| def diy(self, args): | |||
| tty.warn("`spack diy` is deprecated in favor of `spack dev-build`.") | |||
There was a problem hiding this comment.
This should really say that all the functionality of diy has moved to dev-build, and that the diy command will be removed in a future Spack version.
To remove redundant code, I would recommend that we implement diy the same way spack compilers is implemented -- that is, delete all the code here and have the parser setup and the code in this method call dev-build. You can just import spack.cmd.diy and call its methods.
tgamblin
approved these changes
Oct 24, 2019
jrmadsen
pushed a commit
to jrmadsen/spack
that referenced
this pull request
Oct 30, 2019
Rename the `spack diy` command to `spack dev-build` to make the use case clearer. The `spack diy` command has some useful functionality for developers using Spack to build their dependencies and configure/build/install the code they are developing. Developers do not notice it, partly because of the obscure name. The `spack dev-build` command has a `-u/--until PHASE` option to stop after a given phase of the build. This can be used to configure your project, run cmake on your project, or similarly stop after any stage of the build the user wants. These options are analogous to the existing `spack configure` and `spack build` commands, but for developer builds. To unify the syntax, we have deprecated the `spack configure` and `spack build` commands, and added a `-u/--until PHASE` option to the `spack install` command as well. The functionality in `spack dev-build` (specifically `spack dev-build -u cmake`) may be able to supersede the `spack setup` command, but this PR does not deprecate that command as that will require slightly more thought.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3642.
We've decided to rename the
spack diycommand tospack dev-buildto make the use case clearer.The
spack diycommand has some useful functionality for developers using Spack to build their dependencies and configure/build/install the code they are developing. We've realized that as this becomes a developer tool, the namespack diyis less useful. Hence the rename.The
spack dev-buildcommand has a-u/--until PHASEoption to stop after a given phase of the build. This can be used to configure your project, run cmake on your project, or similarly stop after any stage of the build the user wants. These options are analogous to the existingspack configureandspack buildcommands, but for developer builds. To unify the syntax, we have deprecated thespack configureandspack buildcommands, and added a-u/--until PHASEoption to thespack installcommand.I believe the functionality in
spack dev-build(specificallyspack dev-build -u cmake) can supersede thespack setupcommand, but this PR does not deprecate that command as that will require slightly more thought.