-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mark conflicts between newer packages and Intel 14 compilers #13729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Intel 14 lacks some C++11 features needed to compile new versions of cmake. ``` /tmp/s3j/spack-stage/spack-stage-cmake-3.15.5-46lgp4ybhopy2p4rr66rxnew5iaddvmg/spack-src/Source/ cm_static_string_view.hxx(28): error: expected an operator friend static_string_view operator"" _s(const char* data, size_t ^ ```
With Intel 14.0.4 on Linux for icu4c 60.1 and higher: ``` locid.cpp(1156): error spack#1140: a using-declaration may not name a constructor or destructor using KeywordEnumeration::KeywordEnumeration; ```
Error installing `nasm@2.14.02%intel@14.0.4`: ``` In file included from nasmlib/crc64.c(35): ./include/nasmlib.h(116): error: expected a ";" fatal_func nasm_assert_failed(const char *, int, const char *); ```
Installing `bison@3.4.2%intel@14.0.4`: ``` In file included from /tmp/s3j/spack-stage/spack-stage-bison-3.4.2- uzjszv4owvqsymjpxtxvvegfavc6k5my/spack-src/lib/quotearg.c(33): /tmp/s3j/spack-stage/spack-stage-bison-3.4.2-uzjszv4owvqsymjpxtxvvegfavc6k5my/spack-src/lib/ xalloc.h(51): warning spack#303: explicit type is missing ("int" assumed) extern _Noreturn void xalloc_die (void); ```
With `icu4c@60.1%intel@16.0.4` and `icu4c@64.1%intel@16.0.4`: ``` In file included from ucurr.cpp(26): static_unicode_sets.h(130): error spack#913: invalid multibyte character sequence {POUND_SIGN, u'£'}, ^ ```
5d87a2e
to
dc58140
Compare
Fixed version specs (it's hard to remember the convention that Spack ranges, unlike Python ranges, are inclusive on both ends) |
adamjstewart
approved these changes
Nov 14, 2019
Thanks @adamjstewart for the speedy (and frequent) reviews and merges! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently had to build out a compiler toolchain using Intel 14.0.4, which supports most but not all of C++11 and C11 features. I found the oldest Spack-defined versions of each package that failed Intel 14 and marked as conflicts the newer versions with Intel 14 and before.
For posterity, here is what I successfully installed:
This is with Intel pointing to a GCC 4.8.3 installation for libstdc++, with the compiler definition: