Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 nitpicks @becker33:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could put
os=fe target=fe
in, although that would require a bit more refactoring. Not too much though.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tgamblin on point 1, the target of a compiler and the target for which a compiler package is built are different things. We definitely want the compiler target to be the family, because that controls which processors it knows about for cross-compilation. But some users probably want their compilers built for the fastest architecture they can, to speed up build times. I don't know how much of a difference in build time it makes to build the compiler for
broadwell
vsx86_64
, but it could be enough to be worth something.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I will merge this for now (cc: @scottwittenburg), and this may not even be an issue when compilers are dependencies. I definitely think there is some stuff we need to flesh out for compiler modeling.
The way we currently handle the
target
attribute is not quite as clear about where the compiler runs and what it targets as I'd like it to be -- I think we use thetarget
for both...