Fix #12228: make environments and --config-scope work #14608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ChristianTackeGSI , I've been swamped with other work and stopped using spack environments for several reasons, so this issue fell down my priority list. |
|
It looks like I should create some unit tests? I have looked into calling |
You can have a look at tests in the |
|
@alalazo |
|
@alalazo any more suggestions on testing this? |
spack#12228 --config-scope incompatible with environments The issue has all the relevant details. Basicly an activated environment and --config-scope do not work together. The fix is by Tim Fuller @tjfulle who gets all the credit for analyzing the problem and suggesting this fix. The fix looks reasonable to me, so I decided to create a PR from it.
ChristianTackeGSI
force-pushed
the
pr/12228-fix-env-and-config-scope
branch
from
4adc347
to
7f99f98
Compare
|
Close/reopen to restart tests |
scheibelp
approved these changes
Jul 20, 2020
|
Thanks @ChristianTackeGSI and @tjfulle for working on this! |
|
Thanks @scheibelp ! :-) |
dennisklein
pushed a commit
to FairRootGroup/spack
that referenced
this pull request
Aug 10, 2020
…pack#14608) Spack did not support usage of the `--config-scope` option in combination with an environment: In `lib/spack/spack/main.py`, `spack.config.command_line_scopes` is set equal to any config scopes passed by the `--config-scope` option. However, this is done after activating an environment. In the process of activating an environment, the `spack.config.config` singleton is instantiated, so later setting of `spack.config.command_line_scopes` is ignored. This commit sets command line scopes before activating an environment to ensure that they are included in the configuration. Co-authored-by: Tim Fuller <tjfulle@sandia.gov>
dennisklein
pushed a commit
to FairRootGroup/spack
that referenced
this pull request
Aug 20, 2020
…pack#14608) Spack did not support usage of the `--config-scope` option in combination with an environment: In `lib/spack/spack/main.py`, `spack.config.command_line_scopes` is set equal to any config scopes passed by the `--config-scope` option. However, this is done after activating an environment. In the process of activating an environment, the `spack.config.config` singleton is instantiated, so later setting of `spack.config.command_line_scopes` is ignored. This commit sets command line scopes before activating an environment to ensure that they are included in the configuration. Co-authored-by: Tim Fuller <tjfulle@sandia.gov>
Jordan474
pushed a commit
to Jordan474/spack
that referenced
this pull request
Feb 10, 2021
…pack#14608) Spack did not support usage of the `--config-scope` option in combination with an environment: In `lib/spack/spack/main.py`, `spack.config.command_line_scopes` is set equal to any config scopes passed by the `--config-scope` option. However, this is done after activating an environment. In the process of activating an environment, the `spack.config.config` singleton is instantiated, so later setting of `spack.config.command_line_scopes` is ignored. This commit sets command line scopes before activating an environment to ensure that they are included in the configuration. Co-authored-by: Tim Fuller <tjfulle@sandia.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #12228
The issue has all the relevant details. Basically an activated environment and
--config-scopedo not work together.The fix is by Tim Fuller @tjfulle who gets all the credit for analyzing the problem and suggesting this fix.
The fix looks reasonable to me, so I decided to create a PR from it.