externals: allow package prefs to configure default not buildable #16735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becker33
force-pushed
the
features/buildable-false-all
branch
from
c635ec1
to
ae544ce
Compare
tgamblin
requested changes
May 20, 2020
| # Does this spec override all_buildable | ||
| spec_reversed = (spec.name in reverse or | ||
| any(spec.package.provides(name) for name in reverse)) | ||
| return not all_buildable if spec_reversed else all_buildable |
There was a problem hiding this comment.
Proposed simpler formulation:
# prefer specific setting for buildable
buildable = allpkgs.get(spec.name, {}).get("buildable")
# default to "all" setting
if buildable is None:
buildable = allpkgs.get("all", {}).get("buildable", True)This is also O(1) instead of O(n).
There was a problem hiding this comment.
Doesn't work for virtuals.
That's the obvious way of doing this if we didn't have #14934, but we don't have a good interface to go from spec to all virtuals it provides, which is why I went this route when creating that PR.
tgamblin
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16734
Allows
allto be configured non-buildable in packages.yaml.The following config would only allow zlib to be built by Spack, all other packages would have to be found as externals.
includes