clear mpicc and friends before each build #17450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
becker33
requested changes
Jul 9, 2020
becker33
requested changes
Jul 9, 2020
lib/spack/spack/build_environment.py
Outdated
| # Unset mpi environment vars. These flags should only be set by | ||
| # mpi providers for packages with mpi dependencies | ||
| mpi_vars = [ | ||
| 'MPICC', 'MPICXX', 'MPIFC', 'MPIF70', 'MPIF90' |
There was a problem hiding this comment.
Suggested change
| 'MPICC', 'MPICXX', 'MPIFC', 'MPIF70', 'MPIF90' | |
| 'MPICC', 'MPICXX', 'MPIFC', 'MPIF77', 'MPIF90' |
There was a problem hiding this comment.
Apologies for resolving the prior thread while overlooking that suggestion.
becker33
approved these changes
Jul 9, 2020
|
@scheibelp do you want this in 0.15.1 or 0.15.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17322
@becker33