Fix security issue in CI #17545
Merged
Fix security issue in CI #17545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Curiously github is not picking up a force push |
haampie
force-pushed
the
fix-ci-security
branch
2 times, most recently
from
00ea9f0
to
ba2f3fe
Compare
|
Thanks @haampie, this is a good catch. Do you think there might ever a need to be able to upload this artifact (e.g. in a private gitlab instance)? It could be an option which defaults to not uploading it. Otherwise I think I'm fine if it never gets uploaded. Obviously I'm never looking at it, I just thought it would be useful at one point, so I added it. |
scottwittenburg
approved these changes
Jul 15, 2020
There was a problem hiding this comment.
This looks good to me, thanks @haampie! Can this be backported to the current v0.15 release? I'm not sure of the process for that.
Though it's just failing a test, which should be easy to fix, I can push a commit on this branch if you want.
adamjstewart
approved these changes
Jul 16, 2020
alalazo
approved these changes
Jul 16, 2020
scottwittenburg
added a commit
to scottwittenburg/spack
that referenced
this pull request
Jul 17, 2020
The `spack-build-env.txt` file may contains many secrets, but the obvious one is the private signing key in `SPACK_SIGNING_KEY`. This file is nonetheless uploaded as a build artifact to gitlab. For anyone running CI on a public version of Gitlab this is a major security problem. Even for private Gitlab instances it can be very problematic. Co-authored-by: Scott Wittenburg <scott.wittenburg@kitware.com>
scottwittenburg
added a commit
to scottwittenburg/spack
that referenced
this pull request
Jul 21, 2020
The `spack-build-env.txt` file may contains many secrets, but the obvious one is the private signing key in `SPACK_SIGNING_KEY`. This file is nonetheless uploaded as a build artifact to gitlab. For anyone running CI on a public version of Gitlab this is a major security problem. Even for private Gitlab instances it can be very problematic. Co-authored-by: Scott Wittenburg <scott.wittenburg@kitware.com>
scottwittenburg
added a commit
to scottwittenburg/spack
that referenced
this pull request
Jul 21, 2020
The `spack-build-env.txt` file may contains many secrets, but the obvious one is the private signing key in `SPACK_SIGNING_KEY`. This file is nonetheless uploaded as a build artifact to gitlab. For anyone running CI on a public version of Gitlab this is a major security problem. Even for private Gitlab instances it can be very problematic. Co-authored-by: Scott Wittenburg <scott.wittenburg@kitware.com>
becker33
pushed a commit
that referenced
this pull request
Jul 23, 2020
The `spack-build-env.txt` file may contains many secrets, but the obvious one is the private signing key in `SPACK_SIGNING_KEY`. This file is nonetheless uploaded as a build artifact to gitlab. For anyone running CI on a public version of Gitlab this is a major security problem. Even for private Gitlab instances it can be very problematic. Co-authored-by: Scott Wittenburg <scott.wittenburg@kitware.com>
scottwittenburg
added a commit
to scottwittenburg/spack
that referenced
this pull request
Jul 28, 2020
This reverts commit 24dff9c. keys, aws credentials, etc from the CI process. But the spack-build.env file can be useful for reproducing CI builds on the command line, so now we first filter out the secrets before writing the environment file, then continue uploading it as an artifact like before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
spack-build-env.txtfile may contains many secrets, but the obvious one is the private signing key inSPACK_SIGNING_KEY. This file is nonetheless uploaded as a build artifact to gitlab. For anyone running CI on a public version of Gitlab this is a major security problem. Even for private Gitlab instances it can be very problematic.