bmake: fix compile error and update version

[darmac]

No description provided.

[alalazo]

Could you please give more details on the compiler error you are facing and how this PR solves the issue? Also can you remove commented code from the recipe?

[adamjstewart]

The reason that this originally used Package instead of AutotoolsPackage is that by bootstrapping the program, we can build make without relying on a previously existing make on the system. I'm not sure if anyone has actually used it for that purpose, but this change makes it impossible to bootstrap make without an external make command.

[darmac]

Got it.
How about this one? 75467cd

[darmac]

Could you please give more details on the compiler error you are facing and how this PR solves the issue? Also can you remove commented code from the recipe?

Error log as below:

[root@Estuary-CentOS8 packages]# spack install -v bmake@20171207
==> Installing bmake
==> No binary for bmake found: installing from source
==> bmake: Executing phase: 'configure'
==> [2020-08-10-19:08:46.631537] '/usr/bin/sh' 'boot-strap' 'op=configure'
NOTE: default prefix=/usr/local
Usage:
boot-strap [--<configure_arg> ...][<prefix>][--install]
==> Error: ProcessError: Command exited with status 1:
    '/usr/bin/sh' 'boot-strap' 'op=configure'
See build log for details:
  /tmp/root/spack-stage/spack-stage-bmake-20171207-widv4b5muq4464xqbyp73hsrolirpf7c/spack-build-out.txt

[adamjstewart]

Okay, I'm taking a closer look into this. When I wrote #8221 those commands worked just fine. They still work fine when run from the command-line, but fail for some reason when run via Spack. According to the README, the way we had it is the recommended installation method:

The preferred way to bootstrap bmake is::

        ./bmake/boot-strap

there are a number of args - most of which get passed to configure,
eg.
::

        ./bmake/boot-strap --prefix=/opt

see the boot-strap script for details.

For folk that hate to read anything, since 20121212 you can also use
the GNU standard process of::

        ./configure; make; make install

[adamjstewart]

Figured it out. At some point, the way in which we staged the package changed. If you extract the tarball, it creates a directory bmake, and things run fine. But Spack creates a directory spack-src, and things won't build anymore.

I think there are a couple of possible solutions here. We could patch boot-strap to work in spack-src, or we could undo the commit that renames the extracted directory to spack-src.

[adamjstewart]

@tldahlgren it looks like #11528 broke the bmake package. Can you investigate this?

bmake builds fine if the tarball is extracted into a bmake directory, but fails when extracted into a spack-src directory. It looks like the bmake directory is hard-coded into the boot-strap script.

[adamjstewart]

@darmac this fixed the package for me:

diff --git a/var/spack/repos/builtin/packages/bmake/package.py b/var/spack/repos/builtin/packages/bmake/package.py
index 8d103513f5..142f7ba136 100644
--- a/var/spack/repos/builtin/packages/bmake/package.py
+++ b/var/spack/repos/builtin/packages/bmake/package.py
@@ -20,6 +20,9 @@ class Bmake(Package):
     def patch(self):
         # Do not pre-roff cat pages
         filter_file('MANTARGET?', 'MANTARGET', 'mk/man.mk', string=True)
+        # boot-strap hardcodes the directory it expects to be extracted to
+        filter_file('GetDir /bmake', 'GetDir ' + self.stage.source_path,
+                    'boot-strap', string=True)
 
     def configure(self, spec, prefix):
         sh = which('sh')

Just make sure it applies to all versions of the package and I think this solution should be best.

[darmac]

Just make sure it applies to all versions of the package and I think this solution should be best.

OK, I tried your patch with bmake@20180512 and bmake@20200710,
They can both build pass.
c2ff2a7