Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for relocating buildcache binaries with relative rpaths: #19061

Merged
merged 1 commit into from
Oct 1, 2020
Merged

Fixes for relocating buildcache binaries with relative rpaths: #19061

merged 1 commit into from
Oct 1, 2020

Conversation

gartung
Copy link
Member

@gartung gartung commented Sep 30, 2020

  • remove duplication of reconstructed rpaths caused by multiple identical entries in prefixes dictionary
  • don't rewrite rpaths if relative rpaths are unchanged because the directory layout is unchanged

@gartung
Fixed for relocating buildcache binaries with relative rpaths:
9b3b87a 
* remove duplication of reconstructed rpaths caused by multiple identical entries in prefixes dictionary
* don't rewrite rpaths if relative rpaths are unchanged because the directory layout is unchanged
@gartung gartung changed the title Fixed for relocating buildcache binaries with relative rpaths: Fixes for relocating buildcache binaries with relative rpaths: Sep 30, 2020
@gartung gartung mentioned this pull request Sep 30, 2020
Closed
@gartung
Copy link
Member Author

gartung commented Sep 30, 2020

closes #19028

@eugeneswalker
Copy link
Contributor

This solved the issue for me!

@gartung
Copy link
Member Author

gartung commented Oct 1, 2020

@scottwittenburg can you review this PR please.

@gartung gartung added this to Review in progress in Spack v0.15.5 release Oct 1, 2020
@gartung gartung moved this from Review in progress to In progress in Spack v0.15.5 release Oct 1, 2020
@scheibelp scheibelp self-assigned this Oct 1, 2020
Spack v0.15.5 release automation moved this from In progress to Reviewer approved Oct 1, 2020
@scheibelp scheibelp merged commit a279551 into develop Oct 1, 2020
Spack v0.15.5 release automation moved this from Reviewer approved to Done Oct 1, 2020
@scheibelp scheibelp deleted the gartung-bindist-remove-duplicate-rel-rpaths branch October 1, 2020 20:21
robertu94 pushed a commit to robertu94/spack that referenced this pull request Oct 2, 2020
@gartung @robertu94
Binary caching: avoid duplicate RPATHs, unnecessary updates (spack#19061
c1fa8c8 
)

* Remove duplication of reconstructed RPATHs caused by multiple
  identical entries in prefixes dictionary
* Don't rewrite RPATHs if relative RPATHs are unchanged because the
  directory layout is unchanged
@eugeneswalker eugeneswalker linked an issue Oct 11, 2020 that may be closed by this pull request
mpich non-functional when relocated from build cache with relative paths #19028
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheibelp scheibelp scheibelp approved these changes

@becker33 becker33 Awaiting requested review from becker33

@alalazo alalazo Awaiting requested review from alalazo

@tldahlgren tldahlgren Awaiting requested review from tldahlgren

Assignees

@scheibelp scheibelp

Labels
binary-packages buildcache e4s ecp
Projects
No open projects
Spack v0.15.5 release
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mpich non-functional when relocated from build cache with relative paths
3 participants
@gartung @eugeneswalker @scheibelp