Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add patches to bootstrap z3 with python 2.6 #20219

Closed
wants to merge 3 commits into from

Conversation

cosmicexplorer
Copy link
Contributor

Problem

We are currently investigating whether z3 can be used instead of clingo for the new concretizer (from #19501). That work is on https://github.com/spack/spack/tree/z3-concretizer -- it doesn't work yet. If we do use z3, some changes will be necessary to support building with python 2.6.

This diff is on top of #20218, see https://github.com/spack/spack/compare/py26-bootstrap...z3-bootstrap-2.6?expand=1 for the diff on top of that change.

Solution

  • Add several patches to remove '{}'.format(...) calls, which must be converted to '{0}'.format(...) for python 2.6.

Result

  • z3 should be bootstrappable in an environment with only python 2.6 and a C++ compiler. However, this PR should be closed if we find that it is infeasible to use z3 for the new concretizer.

TODO

create a reasonable variant of python to build from scratch

add todo
@cosmicexplorer cosmicexplorer added this to In progress in z3 concretizer via automation Dec 22, 2020
@adamjstewart adamjstewart added bootstrap Anything that has to do with Spack building its own dependencies. concretization labels Dec 25, 2020
@cosmicexplorer
Copy link
Contributor Author

This no longer appears to be necessary after dropping python 2.6 support!

@haampie haampie deleted the z3-bootstrap-2.6 branch August 2, 2022 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bootstrap Anything that has to do with Spack building its own dependencies. concretization
Projects
No open projects
z3 concretizer
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants