add patches to bootstrap z3 with python 2.6 #20219
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are currently investigating whether z3 can be used instead of clingo for the new concretizer (from #19501). That work is on https://github.com/spack/spack/tree/z3-concretizer -- it doesn't work yet. If we do use z3, some changes will be necessary to support building with python 2.6.
This diff is on top of #20218, see https://github.com/spack/spack/compare/py26-bootstrap...z3-bootstrap-2.6?expand=1 for the diff on top of that change.
Solution
'{}'.format(...)
calls, which must be converted to'{0}'.format(...)
for python 2.6.Result
TODO