Fix hip patch version number #20780
Merged
Fix hip patch version number #20780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's two issues with hip where it tries to autodetect the patch version number from git (when installed), but it does not check if it even is inside of a git repo. The result is we end up with a shared lib with a trailing dash in the library suffix: `libamd64.so.x.y.z-`, which confuses GCC. The patch tries to check if the `.git` folder exists, and if it does not, it handles version numbering the same as when git was not installed previously.
haampie
force-pushed
the
fix-hip-again-again
branch
from
99ed9e7
to
e92b846
Compare
haampie
changed the title
|
I have reviewed this change, seems to be good!!. |
alalazo
approved these changes
Jan 12, 2021
loulawrence
pushed a commit
to loulawrence/spack
that referenced
this pull request
Jan 19, 2021
There's two issues with hip where it tries to autodetect the patch version number from git (when installed), but it does not check if it even is inside of a git repo. The result is we end up with a shared lib with a trailing dash in the library suffix: `libamd64.so.x.y.z-`, which confuses GCC. The patch tries to check if the `.git` folder exists, and if it does not, it handles version numbering the same as when git was not installed previously.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ping @srekolam. Currently builds of hip result in shared libs having suffixes like
libamdhip.so.x.y.z-with a trailing dash. This is because hip insists on using git to set the patch version number. The problem is there is no git repo to use when downloading tarballs. This resulted in build errors in some cases when using targets fromhip-config.cmake.Upstream PR: ROCm/HIP#2218