Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby: set JIT compiler path #21842

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

ruby: set JIT compiler path #21842

wants to merge 1 commit into from

Conversation

holrock
Copy link
Contributor

@holrock holrock commented Feb 22, 2021

ruby-JIT needs callable MJIT_CC path in runtime.

Normally JIT uses CC path with compiled. ruby configure.ac
but lib/spack/spack/env/cc can't call directly.

current:

$ ruby --jit --jit-verbose=1 /tmp/bench.rb
Spack compiler must be run from Spack! Input 'SPACK_ENV_PATH' is missing.
MJIT warning: Making precompiled header failed on compilation. Stopping MJIT worker...

fixed:

$ ruby --jit --jit-verbose=1 /tmp/bench.rb
JIT success (53.3ms): block (4 levels) in <main>@/tmp/bench.rb:9 -> /tmp/_ruby_mjit_p13565u1.c
JIT success (95.1ms): block (3 levels) in <main>@/tmp/bench.rb:8 -> /tmp/_ruby_mjit_p13565u2.c
JIT success (58.6ms): block (5 levels) in <main>@/tmp/bench.rb:16 -> /tmp/_ruby_mjit_p13565u3.c
JIT success (848.0ms): @<internal:kernel>:89 -> /tmp/_ruby_mjit_p13565u4.c
Successful MJIT finish

ruby-JIT needs callable CC path in runtime.
@alalazo
Copy link
Member

alalazo commented Feb 20, 2023

That was meant to be fixed in #17141 Will double check this PR. Sorry it went out of our radars.

@becker33
Copy link
Member

becker33 commented Jun 5, 2024

@alalazo were you able to confirm whether this is still necessary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants