bump up version for rccl for rocm-4.1.0 release

[srekolam]

@haampie , while updating the version for rccl package for rocm-4.1.0 i see an error as below. I see similar error with respect to few other packages for rocm-4.1.0 eg -hipcub, rocprim,rocrand etc..
Any thoughts ?
rccl_4.1.0_spack-build-out.txt

[haampie]

Can you check this with your team?

Between 4.0.0 and 4.1.0 it seems HIP_LIB_PATH has changed from hip-4.0.0-.../lib to hip-rocclr-4.1.0-.../lib

[srekolam]

@haampie , i have updated versions for rocm-4.1.0 as well as fixed the issue mentioned with hip package - #22768

[alalazo]

Is there any reason this patch is not getting merged upstream?

[haampie]

ROCm/HIP#2218 I tried. Let me bump that thread again.

[alalazo]

@haampie I saw that, and I think the patch is appropriate. I was wondering though why it is not accepted, since it seems we have to maintain slightly modified versions of it for different version ranges of the package 🙁

[haampie]

Yeah... another way to fix it is to use git instead of tarballs, but I think they should just support non-git builds.

[haampie]

@srekolam can you maybe fix this wrong -L flag issue by setting HIP_LIB_PATH as (yet) another environment variable to hip's lib folder?

The HIP_ROCCLR_... var should not be set because of this in HIP:

if (defined $HIP_ROCCLR_HOME) {
    $HIP_INFO_PATH= "$HIP_ROCCLR_HOME/lib/.hipInfo";
} else {
    $HIP_INFO_PATH= "$HIP_PATH/lib/.hipInfo"; # use actual file
}

there is no .hipInfo in the rocclr/lib folder.

[srekolam]

can i get PR approved. did not see any changes to be made..

[haampie]

Can you set the HIP_LIB_PATH env variable to <hip prefix>/lib? That way we would not hit these branches:

https://github.com/ROCm-Developer-Tools/HIP/blob/rocm-3.9.0/bin/hipcc#L162
https://github.com/ROCm-Developer-Tools/HIP/blob/rocm-4.1.0/bin/hipcc#L125

[srekolam]

@haampie , i think it is not required .. i looked at hip@4.0.0 and before and i see it existed before similar to what is in hip@4.1.0. Any way if required, i will need to check with the HIP team and propose to bring it in a new pr.

[haampie]

Okay, let's do that seperately then