Add AMPL package #23974
Add AMPL package #23974
Conversation
|
This is failing style checks. |
|
@robgics Currently there's this style issue: Feel free to ping me when solved. |
|
How do I ping you? I should have run the style test locally, as that seems to work (though unit-tests don't). I fixed the extra lines. I've never pull-requested before...do I just commit my changes and "resubmit" this pull request? |
|
Ok, I see that committing automatically updates the pull request, and that it failed again. It's complaining about a license thing. I take it that's not part of "style", because the style test did not complain about that when I ran locally. |
|
Ok, I admit, I can't figure out what the "expected license" is that Spack wants. |
| # Copyright 2013-2021 Lawrence Livermore National Security, LLC and other | ||
| # Spack Project Developers. See the top-level COPYRIGHT file for details. | ||
| # SPDX-License-Identifier: (Apache-2.0 OR MIT) |
There was a problem hiding this comment.
All the packages start with:
| # Copyright 2013-2021 Lawrence Livermore National Security, LLC and other | |
| # Spack Project Developers. See the top-level COPYRIGHT file for details. | |
| # SPDX-License-Identifier: (Apache-2.0 OR MIT) | |
| # Copyright 2013-2021 Lawrence Livermore National Security, LLC and other | |
| # Spack Project Developers. See the top-level COPYRIGHT file for details. | |
| # | |
| # SPDX-License-Identifier: (Apache-2.0 OR MIT) |
Please restore the extra line 🙂
There was a problem hiding this comment.
I removed it because it was still giving me the general license error and I was trying to match it with what was in cmd/license.py. Once I removed it, I've now passed the tests. I will add the line back in and commit again.
|
If this works, I need to make this change in the branch I have created for this, not in "develop". |
|
Doing this according to the contrib guide, in a specific branch. |
No description provided.