-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FBGEMM: GCC 5+ and AVX2 required #24356
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Awaiting feedback from @dskhudia before enabling merge. |
@@ -35,4 +35,12 @@ class Fbgemm(CMakePackage): | |||
depends_on('python', type='build') | |||
depends_on('llvm-openmp', when='%apple-clang') | |||
|
|||
conflicts('%gcc@:4', msg='FBGEMM requires GCC 5+') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this make sure that we are running using GCC5+?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, if the user tries to use GCC 4 or older, it will error out and print this message.
Btw, Spack supports several different compilers, so if you know the minimum version of other compilers we can add those too.
https://github.com/pytorch/FBGEMM#dependencies
@dskhudia