Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding ability to compare git references to spack install #24639

Merged
merged 65 commits into from
Sep 15, 2021
Merged

Adding ability to compare git references to spack install #24639

merged 65 commits into from
Sep 15, 2021

Commits on Jul 1, 2021

  1. adding ability to compare git references to spack install 

    This works by way of adding a property, is_commit, to a version, and then given that a version
is a commit, we return a GitFetcherStrategy to use it. In additional, we instruct
the version command to generate a lookup of commits that keeps track of the order
(for comparing between commits) and the previous and next spack version (for comparison
of a commit with a spack version string). If the commit does not have known releases before
it, then the previous is None and we cannot determine the relationship and return False.
The same is true if the commit does not have any known releases after it, although it
is unlikely to hit this case unless the user is asking for a version that has been
released but not added to spack.

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Jul 1, 2021
    Configuration menu
    Copy the full SHA
    090c798 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2021

  1. Merge branch 'develop' into add/github-version-comparison

    @vsoch
    vsoch committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    3a23a34 View commit details
    Browse the repository at this point in the history

  2. fixing isort issues 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Jul 9, 2021
    Configuration menu
    Copy the full SHA
    ed4a3c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2021

  1. use pkg.git over pkg.url for git fetches

    @becker33
    becker33 committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    7e7cf9f View commit details
    Browse the repository at this point in the history

  2. ensuring that we strip .git from a repository url, otherwise the outp… 

    …ut folder != the expected name

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    be4a574 View commit details
    Browse the repository at this point in the history

  3. ensure we do not compare versions if either the primary or other vers… 

    …ion is a commit, and we have not indexed commits yet

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Jul 20, 2021
    Configuration menu
    Copy the full SHA
    d2a9101 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2021

  1. we cannot check for commit versions if the package does not have a gi… 

    …t attribute

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    dd09212 View commit details
    Browse the repository at this point in the history

  2. cannot use rstrip as it also strips other letters in the string, usin… 

    …g re instead

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    3f14ff7 View commit details
    Browse the repository at this point in the history

  3. generate commit lookups for dev specs when added to concretization

    @becker33
    becker33 committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    20534e5 View commit details
    Browse the repository at this point in the history

  4. type safety for Version.__lt__ and Version.satisfies

    @becker33
    becker33 committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    534b7a6 View commit details
    Browse the repository at this point in the history

  5. user other.commits if it exists and self.commits does not

    @becker33
    becker33 committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    58e9b10 View commit details
    Browse the repository at this point in the history

  6. fall back on prev_version in Version.__contains__

    @becker33
    becker33 committed Jul 21, 2021
    Configuration menu
    Copy the full SHA
    6b8be68 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2021

  1. fix undefined variable

    @becker33
    becker33 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    7ee3d79 View commit details
    Browse the repository at this point in the history

  2. move version lookup to post-parse pass

    @becker33
    becker33 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    60692c0 View commit details
    Browse the repository at this point in the history

  3. add line in fetch_strategy.py for flake

    @becker33
    becker33 committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    364ab4b View commit details
    Browse the repository at this point in the history

  4. adding test for clone by command and supporting filesystem clone 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    7d0795f View commit details
    Browse the repository at this point in the history

  5. style fixes 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    ed3e43d View commit details
    Browse the repository at this point in the history

  6. ensure we tell git who we are 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Jul 22, 2021
    Configuration menu
    Copy the full SHA
    e9d08a5 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2021

  1. Adding comment about generating commit lookup

    @vsoch
    vsoch committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    7281bfb View commit details
    Browse the repository at this point in the history

  2. small updates to fetch strategy docs and version 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    0534420 View commit details
    Browse the repository at this point in the history

  3. invalid syntax? 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    92dcbd8 View commit details
    Browse the repository at this point in the history

  4. updating logic in commit parsing 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    f19ec90 View commit details
    Browse the repository at this point in the history

  5. commits is never used 

    Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    cddea2e View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Can git repo change to have >= 5 branches?

    @vsoch
    vsoch committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    1acb19a View commit details
    Browse the repository at this point in the history

  2. refactor clone method signature

    @becker33
    becker33 committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    10c59cd View commit details
    Browse the repository at this point in the history

  3. do not require that a fetcher only has one branch, tag, or commit 

    it is possible that we create a fetcher for a branch/tag, but then use a commit

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
    @vsoch
    vsoch committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    344f88c View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2021

  1. Make sure that git log gets --all commits

    @vsoch
    vsoch committed Aug 29, 2021
    Configuration menu
    Copy the full SHA
    71fe3eb View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2021

  1. try using tuples with empty string delimiter

    @becker33
    becker33 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    ed81ede View commit details
    Browse the repository at this point in the history

  2. flake

    @becker33
    becker33 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    e70e542 View commit details
    Browse the repository at this point in the history

  3. typo bugfix

    @becker33
    becker33 committed Aug 30, 2021
    Configuration menu
    Copy the full SHA
    6e110b1 View commit details
    Browse the repository at this point in the history

Commits on Sep 2, 2021

  1. fixup test for more robust git repo

    @becker33
    becker33 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    7f0d7ba View commit details
    Browse the repository at this point in the history

  2. make git commit install test stricter

    @becker33
    becker33 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    8a40af7 View commit details
    Browse the repository at this point in the history

  3. test for comparing git versions

    @becker33
    becker33 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    b4d58a3 View commit details
    Browse the repository at this point in the history

  4. minor fixes to git version lookups

    @becker33
    becker33 committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    b217616 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. flake

    @becker33
    becker33 committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    a832244 View commit details
    Browse the repository at this point in the history

  2. isort

    @becker33
    becker33 committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    a4557e3 View commit details
    Browse the repository at this point in the history

  3. more isort

    @becker33
    becker33 committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    a93bb56 View commit details
    Browse the repository at this point in the history

  4. fix isort/flake8 issues

    @tgamblin
    tgamblin committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    ea48f30 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. refactor genreate_commit_lookup to instantiate its own fetcher

    @becker33
    becker33 committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    023e34e View commit details
    Browse the repository at this point in the history

  2. refactor git is-ancestor check to avoid try/except

    @becker33
    becker33 committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    1eff677 View commit details
    Browse the repository at this point in the history

  3. refactor to avoid one git request per tag

    @becker33
    becker33 committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    3edccca View commit details
    Browse the repository at this point in the history

  4. fix version comparisons to tags

    @becker33
    becker33 committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    2967a3d View commit details
    Browse the repository at this point in the history

  5. os.makedirs -> llnl.util.filesystem.mkdirp

    @becker33
    becker33 committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    3e135a4 View commit details
    Browse the repository at this point in the history

  6. remove unreachable code block

    @becker33
    becker33 committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    e48f568 View commit details
    Browse the repository at this point in the history

  7. CommitLookup: refactor to lazy cache initialization for performance

    @becker33
    becker33 committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    28a52ca View commit details
    Browse the repository at this point in the history

  8. improve error message and docstring

    @becker33
    becker33 committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    3f4ac09 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. CommitLookup: use misc cache for locking

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    8b5fc5b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'add/github-version-comparison' of github.com:vsoch/spac… 

    …k into add/github-version-comparison
    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    b9a0431 View commit details
    Browse the repository at this point in the history

  3. flake

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    28f9f19 View commit details
    Browse the repository at this point in the history

  4. bugfix: type(distance) must be int

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    7960364 View commit details
    Browse the repository at this point in the history

  5. ensure mock git version repo has distinct commit timestamps

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    0ffaf68 View commit details
    Browse the repository at this point in the history

  6. docstring for mock_git_version_info

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    60f5705 View commit details
    Browse the repository at this point in the history

  7. remove vestigial code from PR

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    5c7329a View commit details
    Browse the repository at this point in the history

  8. improved docstrings and error messages

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    7f10b80 View commit details
    Browse the repository at this point in the history

  9. add spack.util.url.git_url_parse() method and tests 

    Add a method to parse git URLs (but not arbitrary file paths). This method parses git
URLs into scheme, username, hostname, port, and path. It will raise an error if its
argument is not proper git URL.

- [x] add `spack.util.url.git_url_parse` method
- [x] add 31 tests for `git_url_parse`
    @tgamblin
    tgamblin committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    fee95c5 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'add/github-version-comparison' of github.com:vsoch/spac… 

    …k into add/github-version-comparison
    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    4280784 View commit details
    Browse the repository at this point in the history

  11. refactor git parsing to make use of git_url_parse

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    7d7d550 View commit details
    Browse the repository at this point in the history

  12. fix formatting for pytest fixture docstring

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    a254d39 View commit details
    Browse the repository at this point in the history

  13. fix import cycle

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    16fe132 View commit details
    Browse the repository at this point in the history

  14. use bare clones for caching git repos

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    526d6f7 View commit details
    Browse the repository at this point in the history

  15. Merge branch 'develop' into add/github-version-comparison

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    17963d2 View commit details
    Browse the repository at this point in the history

  16. flake

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    f8accd4 View commit details
    Browse the repository at this point in the history

  17. isort

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    d6bfa79 View commit details
    Browse the repository at this point in the history

  18. git_url_parse: fix docstring syntax error

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    2d98944 View commit details
    Browse the repository at this point in the history

  19. minor bugfix

    @becker33
    becker33 committed Sep 14, 2021
    Configuration menu
    Copy the full SHA
    b6214e1 View commit details
    Browse the repository at this point in the history