Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bugs with new package updates for samtools and abi-dumper #25615

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Aug 25, 2021

samtools needed more constraints for htslib, and abi-dumper was missing pkg-config on the dependency universal ctags

You can see successful builds here:

Signed-off-by: vsoch vsoch@users.noreply.github.com

samtools needed more constraints for htslib, and abi-dumper was missing pkg-config
on the dependency universal ctags

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@spackbot-app
Copy link

spackbot-app bot commented Aug 25, 2021

Hi @vsoch! I noticed that the following package(s) don't yet have maintainers:

  • samtools
  • universal-ctags

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['vsoch']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame samtools

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@vsoch
Copy link
Member Author

vsoch commented Aug 25, 2021

No way @spackbot I am not maintainer material!

@alalazo alalazo merged commit 4ddc0ff into spack:develop Aug 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants