Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to prefer particular versions in packages. #261

Merged
merged 1 commit into from
Dec 22, 2015

Conversation

tgamblin
Copy link
Member

This is a stopgap until I can merge PR #120, which includes more robust concretization preferences. This allows any number of versions in a package to be marked preferred=True. Packages are now sorted by preference, then most recent in concretization. So you can mark directly in the package file what the preferred version is.

PR #120 provides the infrastructure we need to express these types of preferences per-platform, per-compiler, etc. but this is a first step. This also allows Python 2.7.11 to remain the default while we get the Python stack working with 3.5.

@lee218llnl @alalazo @mplegendre: What do you think?

  • Adding preferred=True to a version directive will change its sort
    order in concretization.
  • This provides us a rudimentary ability to keep the Spack stack
    stable as new versions are added.
  • Having multiple stacks will come next, but this at least allows us
    to specify default versions of things instead of always taking the
    newest.

- Adding `preferred=True` to a version directive will change its sort
  order in concretization.

- This provides us a rudimentary ability to keep the Spack stack
  stable as new versions are added.

- Having multiple stacks will come next, but this at least allows us
  to specify default versions of things instead of always taking the
  newest.
@tgamblin
Copy link
Member Author

@lee218llnl: does this look ok to you? This will allow you to prefer python 2.7 until 3 is more stable. Also would allow you to designate "stable" versions of other packages

@alalazo
Copy link
Member

alalazo commented Dec 22, 2015

@tgamblin : it seems good to me. As you said it will improve stack stability changing only a few lines of code.

@lee218llnl
Copy link
Contributor

@tgamblin this looks good to me

tgamblin added a commit that referenced this pull request Dec 22, 2015
Add ability to prefer particular versions in packages.
@tgamblin tgamblin merged commit b1d40ef into develop Dec 22, 2015
@tgamblin
Copy link
Member Author

Thanks!

@tgamblin tgamblin deleted the features/prefer-versions-in-packages branch December 23, 2015 01:07
matz-e pushed a commit to matz-e/spack that referenced this pull request Apr 27, 2020
AlexanderRichert-NOAA pushed a commit to AlexanderRichert-NOAA/spack that referenced this pull request Apr 25, 2023
…_jscda_emc_spack_stack

Merge release/1.3.1 into jscda_emc_spack_stack
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants