Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #19736 because conflicts are avoided by clingo by default #26721

Merged
merged 1 commit into from
Oct 18, 2021
Merged

Revert #19736 because conflicts are avoided by clingo by default #26721

merged 1 commit into from
Oct 18, 2021

Conversation

haampie
Copy link
Member

@haampie haampie commented Oct 13, 2021 •
edited
Loading

Clingo toggles to +allow-unsupported-compilers to avoid any conflicts.

@spackbot-app spackbot-app bot requested review from ax3l and Rombur October 13, 2021 20:04
@haampie haampie changed the title Revert 19736 because conflicts are avoided by clingo by default Revert #19736 because conflicts are avoided by clingo by default Oct 13, 2021
@haampie haampie mentioned this pull request Oct 14, 2021
Merged
@ax3l
Copy link
Member

ax3l commented Oct 16, 2021 •
edited
Loading

Oh no, it's too smart.

But if we remove this variant, people cannot ask to ignore unsupported compilers anymore :(

@ax3l ax3l added the cuda label Oct 16, 2021
@ax3l ax3l requested a review from sethrj October 16, 2021 01:04
@sethrj
Copy link
Contributor

sethrj commented Oct 16, 2021

Another case of us using dashes instead of underscores for variant names... ahem #25841 ahem

sethrj
sethrj reviewed Oct 16, 2021
View reviewed changes
Copy link
Contributor

@sethrj sethrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So are you saying that with clingo, +cuda ^cuda@11 %gcc@4 is allowable? I think the point of the PR being reverted was to allow these conflicts to be completely bypassed, not to try to hint to the concretizer.

@ax3l
Copy link
Member

ax3l commented Oct 16, 2021 •
edited
Loading

The problem is that clingo switches the variant that allows manual bypassing of all conflicts to explore (usually newer) compilers from False to True to solve the request.

In other words:

  • before this PR: all conflicts are ignored
  • after this PR: all conflicts in place and cannot be deactivated

@davidbeckingsale added this feature, pinging him on this.
I currently have no idea how we can express this and would thus go ahead merging this revert.

@sethrj
Copy link
Contributor

sethrj commented Oct 17, 2021

Thanks @ax3l for the explanation!

@haampie
Copy link
Member Author

haampie commented Oct 18, 2021 •
edited
Loading

Merging this until we have a better solution, given that the majority of the users benefits from these conflicts.

@davidbeckingsale can always run:

curl -Lfs https://github.com/spack/spack/pull/26721.patch | git apply -R

@haampie haampie merged commit 33ef7d5 into spack:develop Oct 18, 2021
@haampie haampie deleted the revert/19736 branch October 18, 2021 06:41
@ax3l
Copy link
Member

ax3l commented Oct 18, 2021

Chatter on possible solutions continues here: #19736 (comment)

wdconinc pushed a commit to wdconinc/spack that referenced this pull request Oct 23, 2021
@haampie @wdconinc
Revert 19736 because conflicts are avoided by clingo by default (spac…
43ee1f8 
…k#26721)
@alalazo alalazo mentioned this pull request Jan 27, 2022
Merged
4 tasks
alalazo added a commit to alalazo/spack that referenced this pull request Jan 29, 2022
@alalazo
Revert "Revert 19736 because conflicts are avoided by clingo by defau…
8f668f0 
…lt (spack#26721)"

This reverts commit 33ef7d5.
@corbett5
Copy link
Contributor

As a user of Livermore's systems who is still using the default CUDA 10, I always use +allow-unsupported-compilers. Now I have to go and revert this in my fork.

corbett5 added a commit to corbett5/spack that referenced this pull request Jan 31, 2022
@corbett5
Revert "Revert 19736 because conflicts are avoided by clingo by defau…
9beef75 
…lt (spack#26721)"

This reverts commit 33ef7d5.
becker33 pushed a commit that referenced this pull request Feb 2, 2022
@alalazo
Add a "sticky" property to variants (#28630)
cd04109 
* Add sticky variants

* Add unit tests for sticky variants

* Add documentation for sticky variants

* Revert "Revert 19736 because conflicts are avoided by clingo by default (#26721)"

This reverts commit 33ef7d5.

* Add stickiness to "allow-unsupported-compiler"
RikkiButler20 pushed a commit to RikkiButler20/spack that referenced this pull request Feb 8, 2022
@alalazo @RikkiButler20
Add a "sticky" property to variants (spack#28630)
5300f1a 
* Add sticky variants

* Add unit tests for sticky variants

* Add documentation for sticky variants

* Revert "Revert 19736 because conflicts are avoided by clingo by default (spack#26721)"

This reverts commit 33ef7d5.

* Add stickiness to "allow-unsupported-compiler"
EthanS94 pushed a commit to EthanS94/spack that referenced this pull request Feb 17, 2022
@alalazo @EthanS94
Add a "sticky" property to variants (spack#28630)
84abc59 
* Add sticky variants

* Add unit tests for sticky variants

* Add documentation for sticky variants

* Revert "Revert 19736 because conflicts are avoided by clingo by default (spack#26721)"

This reverts commit 33ef7d5.

* Add stickiness to "allow-unsupported-compiler"
olupton pushed a commit to BlueBrain/spack that referenced this pull request Apr 8, 2022
@alalazo @olupton
Add a "sticky" property to variants (spack#28630)
304127b 
* Add sticky variants

* Add unit tests for sticky variants

* Add documentation for sticky variants

* Revert "Revert 19736 because conflicts are avoided by clingo by default (spack#26721)"

This reverts commit 33ef7d5.

* Add stickiness to "allow-unsupported-compiler"
olupton pushed a commit to BlueBrain/spack that referenced this pull request Apr 11, 2022
@alalazo @olupton
Add a "sticky" property to variants (spack#28630)
4e86c75 
* Add sticky variants

* Add unit tests for sticky variants

* Add documentation for sticky variants

* Revert "Revert 19736 because conflicts are avoided by clingo by default (spack#26721)"

This reverts commit 33ef7d5.

* Add stickiness to "allow-unsupported-compiler"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrj sethrj sethrj left review comments

@ax3l ax3l ax3l approved these changes

@Rombur Rombur Awaiting requested review from Rombur

@davidbeckingsale davidbeckingsale Awaiting requested review from davidbeckingsale

Assignees
No one assigned
Labels
build-systems conflicts cuda update-package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@haampie @ax3l @sethrj @corbett5