OpenBLAS: Add a symbol suffix option #27500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
|
@sethrj would you care to have a look at this one too? :D |
|
or maybe @michaelkuhn. @spackbot run pipeline |
|
I had a problem triggering the pipeline. |
|
@spackbot run pipeline |
|
I had a problem triggering the pipeline. |
|
@spackbot run pipeline |
|
I had a problem triggering the pipeline. |
sethrj
previously approved these changes
Nov 17, 2021
sethrj
changed the title
|
Now we just have to convince spackbot it should do something with this PR |
Some packages use a 64_ or _64 symbol suffix for the ilp64 (= 64-bit integers) intefrace for BLAS. In particular if we want to support shim libraries like libopenblastrampoline supporting both the 32 and 64 bit integer version of blas, it must be possible to distinguish between the two.
haampie
force-pushed
the
feature/openblas/symbol_suffix
branch
from
341dcf7
to
946fbc3
Compare
sethrj
approved these changes
Nov 17, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some packages use a
64_or_64symbol suffix for the ilp64 (= 64-bitintegers) interface for BLAS. In particular if we want to support shim
libraries like libopenblastrampoline supporting both the 32 and 64 bit
integer version of blas, it must be possible to distinguish between the
two.