-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding oras go package! #27605
Merged
Merged
Adding oras go package! #27605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalazo
requested changes
Nov 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Basically LGTM, just a couple of minor requests.
vsoch
force-pushed
the
add/oras
branch
2 times, most recently
from
November 23, 2021 16:58
b000fd7
to
7698bc2
Compare
@vsoch Can you rebase? We just removed Python 2.6 support, |
yep |
I am a firm supporting of splooshing Python 2.x it needs to go away!! 😆 |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Okay done! I hope I did that right. |
alalazo
approved these changes
Nov 24, 2021
Thank you! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will add oras!
https://github.com/oras-project/oras
I have some plans to use this to enable oras backed build caches (or at least try :P)
Signed-off-by: vsoch vsoch@users.noreply.github.com