Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding oras go package! #27605

Merged
merged 1 commit into from
Nov 24, 2021
Merged

Adding oras go package! #27605

merged 1 commit into from
Nov 24, 2021

Conversation

vsoch
Copy link
Member

@vsoch vsoch commented Nov 23, 2021

This will add oras!

https://github.com/oras-project/oras

I have some plans to use this to enable oras backed build caches (or at least try :P)

Signed-off-by: vsoch vsoch@users.noreply.github.com

Copy link
Member

@alalazo alalazo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM, just a couple of minor requests.

var/spack/repos/builtin/packages/oras/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/oras/package.py Outdated Show resolved Hide resolved
@vsoch vsoch force-pushed the add/oras branch 2 times, most recently from b000fd7 to 7698bc2 Compare November 23, 2021 16:58
@vsoch
Copy link
Member Author

vsoch commented Nov 23, 2021

Is this a transient error? I've not seen it before.
image

@alalazo
Copy link
Member

alalazo commented Nov 23, 2021

@vsoch Can you rebase? We just removed Python 2.6 support, centos:6 tests shouldn't be running.

@vsoch
Copy link
Member Author

vsoch commented Nov 23, 2021

yep

@vsoch
Copy link
Member Author

vsoch commented Nov 23, 2021

I am a firm supporting of splooshing Python 2.x it needs to go away!! 😆

Signed-off-by: vsoch <vsoch@users.noreply.github.com>
@vsoch
Copy link
Member Author

vsoch commented Nov 23, 2021

Okay done! I hope I did that right.

@vsoch vsoch requested a review from alalazo November 24, 2021 04:57
@alalazo alalazo merged commit a5bd6ac into spack:develop Nov 24, 2021
@vsoch
Copy link
Member Author

vsoch commented Nov 24, 2021

Thank you! 🎉

@vsoch vsoch deleted the add/oras branch November 24, 2021 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants