is_system_path: return False if path is None #28403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalazo
approved these changes
Jan 14, 2022
|
@spackbot run pipeline |
haampie
pushed a commit
that referenced
this pull request
Jan 17, 2022
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 1, 2022
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 1, 2022
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Feb 8, 2022
EthanS94
pushed a commit
to EthanS94/spack
that referenced
this pull request
Feb 17, 2022
alalazo
pushed a commit
that referenced
this pull request
Apr 14, 2022
capitalaslash
pushed a commit
to capitalaslash/spack
that referenced
this pull request
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #28006
fixes #22268
A bit of defensive programming in that a
None(or empty string) is automatically rejected as a system path.This change should prevent the erroneous TypeError reporting for issues such as #28006 and #22268.