Add several new R packages #2952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamjstewart
changed the title
adamjstewart
commented
Jan 28, 2017
| depends_on('r-kernlab', type=('build', 'run')) | ||
| depends_on('r-e1071', type=('build', 'run')) | ||
| depends_on('r-glmnet', type=('build', 'run')) | ||
| depends_on('r-xgboost', type=('build', 'run')) |
There was a problem hiding this comment.
Concretizing this package is absolutely brutal:
$ time spack spec r-rminer
...
real 7m16.433s
user 7m9.730s
sys 0m4.468s
|
Why do the new packages subclass |
|
Hmm, that is a good question, seeing as how it correctly renamed them to |
adamjstewart
changed the title
adamjstewart
commented
Jan 28, 2017
| @@ -249,6 +249,7 @@ def __init__(self, name, *args): | |||
|
|
|||
| class RPackageTemplate(PackageTemplate): | |||
| """Provides appropriate overrides for R extensions""" | |||
| base_class_name = 'RPackage' | |||
There was a problem hiding this comment.
Somehow I completely forgot this in #2761.
This was referenced Jan 28, 2017
|
@adamjstewart: is this WIP? |
|
Well, I haven't yet tried to install any of them, but they shouldn't break anything at least. I was going to install them on Monday 😄 |
|
Ok I'll wait til Monday. |
adamjstewart
changed the title
|
Ok, this should be all of the packages I need for now. I was able to install all of them, but I wasn't able to activate them due to the bug I mentioned in #2951 (comment). |
Closed
diaena
pushed a commit
to diaena/spack
that referenced
this pull request
May 26, 2017
* Add several new R packages * Add a few more R packages * Update more versions * Convert Package to RPackage * Add a few more packages * Add missing dependencies
amklinv
pushed a commit
that referenced
this pull request
Jul 17, 2017
* Add several new R packages * Add a few more R packages * Update more versions * Convert Package to RPackage * Add a few more packages * Add missing dependencies
healther
pushed a commit
to electronicvisions/spack
that referenced
this pull request
Jul 26, 2017
* Add several new R packages * Add a few more R packages * Update more versions * Convert Package to RPackage * Add a few more packages * Add missing dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also updates to the latest version for several existing R packages.