-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hdf5 For Windows #29826
Hdf5 For Windows #29826
Conversation
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a preliminary review with some questions.
I think this could potentially be split into multiple PRs (e.g. the hdf5
changes are useful without the openblas
changes), and that may be preferable if resolving all the questions here takes too much time.
|
||
depends_on('mpi', when='+mpi') | ||
if sys.platform != 'win32': | ||
depends_on('mpi', when='+mpi') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(question) to be clear, does this mean that building hdf5
with MPI support on Windows does not require any install of MPI on the system?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ping - I would have assumed that building hdf5+mpi
on Windows would require an MPI
installation.
@@ -414,7 +421,8 @@ def ensure_parallel_compiler_wrappers(self): | |||
if self.spec.satisfies('@1.8.21:1.8.22,1.10.2:1.10.7,1.12.0+mpi'): | |||
with working_dir(self.prefix.bin): | |||
# No try/except here, fix the condition above instead: | |||
symlink('h5cc', 'h5pcc') | |||
if sys.platform != 'win32': | |||
symlink('h5cc', 'h5pcc') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(question) #27021 added some logic for symlink
analogs on Windows: does this still need to be skipped on Windows?
If so, the following if
block also calls symlink
and should also probably change in that case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ping
…y need to go down CMake route
…ve towards adding logic for other options
…ork with MSVC, use -DTARGET=GENERIC for now
…sn't have a shared build recipe
…onflicts for upstream packages
Would it be worth / possible to delay this until #30411 is in? That PR would allow to distinguish based on
|
This comment was marked as off-topic.
This comment was marked as off-topic.
Close/reopen to restart tests |
Test restart |
Migrated to #31141 on fresh branch |
Includes packaging for hdf5, bzip2, boost, pcre, openblas and sqlite. Also provides the WindowsPackage build system, which allows developers to specify shared, static, and static multithreaded runtime variants of packages.
This branch was rebased on top of develop moments ago so everything should be in order once tests pass