-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
h5z-zfp: Convert to CMakePackage #29952
Conversation
Hi @jrood-nrel! I noticed that the following package(s) don't yet have maintainers:
Are you interested in adopting any of these package(s)? If so, simply add the following to the package class: maintainers = ['jrood-nrel'] If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with $ spack blame h5z-zfp Thank you for your help! Please don't add maintainers without their consent. You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer. |
"""A highly flexible floating point and integer compression plugin for the | ||
HDF5 library using ZFP compression.""" | ||
|
||
homepage = "https://h5z-zfp.readthedocs.io/en/latest" | ||
git = "https://github.com/LLNL/H5Z-ZFP.git" | ||
url = "https://github.com/LLNL/H5Z-ZFP/archive/refs/tags/v1.0.1.tar.gz" | ||
|
||
version('develop', branch='master') | ||
version('develop', branch='master', preferred=True) | ||
version('1.0.1', sha256='b9ed91dab8e2ef82dc6706b4242c807fb352875e3b21c217dd00782dd1a22b24') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CMake build wasn't added until after the 1.0.1 release so none of the specified versions are even valid for this package. @brtnfld can we get a new tag or release of the plugin to use for the package so this doesn't have to try to manage both build systems?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It uses the previous build strategy for the existing versions.
Maybe we can just remove the old versions and make this a |
Seems another case for #30411 |
@jrood-nrel We have support for multiple build systems since v0.19.0 Do you want to rewrite this package to switch the build system? |
Sure. I'm not sue when I will get to it. I will close this until I get to it. |
No description provided.