-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build_env: allowlist rather than blocklist #30015
Open
trws
wants to merge
11
commits into
spack:develop
Choose a base branch
from
trws:env-whitelist
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Commits on Apr 19, 2022
-
build_env: whitelist rather than blacklist
Stop removing environment variables to fix problems and instead nuke them all from orbit, it's the only way to be sure. Less flippantly, this adds a helper function to the env utility to restore an environment variable to its current state after it's been cleared. Then build_environment clears all environment variables, and restores only those variables that we explicitly allow to persist. This solves much of the fragility of building packages that take poorly named common environment variables silently as arguments, such as OpenSSL, but will likely cause breakage for cases where packages happened to accidentally work due to re-using external state that will no longer be visible.
Configuration menu - View commit details
-
Copy full SHA for 9b86641 - Browse repository at this point
Copy the full SHA 9b86641View commit details -
use dirty in the env modification tests so that the modifications app…
…ly to env vars that are otheriwse cleared
Configuration menu - View commit details
-
Copy full SHA for 9ca6062 - Browse repository at this point
Copy the full SHA 9ca6062View commit details -
Configuration menu - View commit details
-
Copy full SHA for aca3a96 - Browse repository at this point
Copy the full SHA aca3a96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0eda725 - Browse repository at this point
Copy the full SHA 0eda725View commit details -
use getpass.getuser() by default, fall back to os.getlogin only for s…
…ystems without pwd module
Configuration menu - View commit details
-
Copy full SHA for a954c69 - Browse repository at this point
Copy the full SHA a954c69View commit details
Commits on Apr 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3235e39 - Browse repository at this point
Copy the full SHA 3235e39View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b34b07 - Browse repository at this point
Copy the full SHA 2b34b07View commit details -
Configuration menu - View commit details
-
Copy full SHA for ebd5d29 - Browse repository at this point
Copy the full SHA ebd5d29View commit details
Commits on Apr 21, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 55c7059 - Browse repository at this point
Copy the full SHA 55c7059View commit details
Commits on Jan 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for cd68fe5 - Browse repository at this point
Copy the full SHA cd68fe5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c3d363 - Browse repository at this point
Copy the full SHA 4c3d363View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.