Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build_env: allowlist rather than blocklist #30015

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Commits on Apr 19, 2022

  1. build_env: whitelist rather than blacklist

    Stop removing environment variables to fix problems and instead nuke
    them all from orbit, it's the only way to be sure.
    
    Less flippantly, this adds a helper function to the env utility to
    restore an environment variable to its current state after it's been
    cleared.  Then build_environment clears all environment variables, and
    restores only those variables that we explicitly allow to persist.
    
    This solves much of the fragility of building packages that take poorly
    named common environment variables silently as arguments, such as
    OpenSSL, but will likely cause breakage for cases where packages
    happened to accidentally work due to re-using external state that will
    no longer be visible.
    trws committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    9b86641 View commit details
    Browse the repository at this point in the history
  2. use dirty in the env modification tests so that the modifications app…

    …ly to env vars that are otheriwse cleared
    trws committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    9ca6062 View commit details
    Browse the repository at this point in the history
  3. fix windows support, refactor

    trws committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    aca3a96 View commit details
    Browse the repository at this point in the history
  4. debugging RTD ioctl failures

    trws committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    0eda725 View commit details
    Browse the repository at this point in the history
  5. use getpass.getuser() by default, fall back to os.getlogin only for s…

    …ystems without pwd module
    trws committed Apr 19, 2022
    Configuration menu
    Copy the full SHA
    a954c69 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2022

  1. comment style fix

    trws committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    3235e39 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2b34b07 View commit details
    Browse the repository at this point in the history
  3. refine importerror check

    trws committed Apr 20, 2022
    Configuration menu
    Copy the full SHA
    ebd5d29 View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2022

  1. Configuration menu
    Copy the full SHA
    55c7059 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2024

  1. Configuration menu
    Copy the full SHA
    cd68fe5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4c3d363 View commit details
    Browse the repository at this point in the history