Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openssl: exclude more dangerous environment variables #30208

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

trws
Copy link
Contributor

@trws trws commented Apr 21, 2022

Minimal set of environment variables added to be cleared for the openssl package, these are used as control variables by openssl and can easily cause configuration and build failures if let through. This is a stopgap while we wait on #30015.

@spackbot-app
Copy link

spackbot-app bot commented Apr 21, 2022

Hi @trws! I noticed that the following package(s) don't yet have maintainers:

  • openssl

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['trws']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame openssl

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@trws trws changed the title openssl: blacklist more dangerous environment variables openssl: exclude more dangerous environment variables Apr 21, 2022
@trws trws requested a review from scheibelp April 21, 2022 18:51
@haampie
Copy link
Member

haampie commented Apr 21, 2022

is this not something you can do in setup_build_environment?

@trws
Copy link
Contributor Author

trws commented Apr 21, 2022

It is, the PR to do this more completely all over the place does that in build_environment's clean stuff in fact, but I put this where it is because that's where the only existing environment cleaning was happening in the package.

@tgamblin tgamblin merged commit 62553e7 into spack:develop Apr 22, 2022
trws added a commit to trws/spack that referenced this pull request Apr 29, 2022
* pkg/openssl: blacklist more dangerous environment variables

* fix style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants