Update Dockerfiles and images for Spack v0.18.0 #30216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alalazo
force-pushed
the
features/update_container_images
branch
from
7e1ba02
to
66013fc
Compare
alalazo
force-pushed
the
features/update_container_images
branch
2 times, most recently
from
13c1b77
to
a6a3e69
Compare
alalazo
force-pushed
the
features/update_container_images
branch
from
a6a3e69
to
df58eba
Compare
alalazo
changed the title
alalazo
force-pushed
the
features/update_container_images
branch
from
a8f4315
to
0e31746
Compare
opadron
approved these changes
Apr 21, 2022
alecbcs
approved these changes
Apr 21, 2022
|
Amazing timing! Ubuntu 22.04 LTS came out (like today? or this week?) and I was just building with spack 18.04 and was like hmmm this is very old do we have a newer one yet? ... and we do! 🥳 |
trws
pushed a commit
to trws/spack
that referenced
this pull request
Apr 29, 2022
This PR updates the list of images we build nightly, deprecating Ubuntu 16.04 and CentOS 8 and adding Ubuntu 20.04, Ubuntu 22.04 and CentOS Stream. It also removes a lot of duplication by generating the Dockerfiles during the CI workflow and uploading them as artifacts for later inspection or reuse.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30211
fixes #21131
fixes #18005
closes #14357
closes #23322
closes #23323
closes #19991
This PR updates the list of images we build nightly, deprecating Ubuntu 16.04 and CentOS 8 and adding Ubuntu 20.04, Ubuntu 22.04 and CentOS Stream. It also removes a lot of duplication by generating the Dockerfiles during the CI workflow and uploading them as artifacts for later inspection or reuse.
Modifications:
spack containerizeand target the currentGITHUB_REF