Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add New Package:PSCMC #30944

Merged
merged 11 commits into from Jun 7, 2022
Merged

Add New Package:PSCMC #30944

merged 11 commits into from Jun 7, 2022

Conversation

Bitllion
Copy link
Contributor

@Bitllion Bitllion commented Jun 1, 2022

No description provided.

@spackbot-app
Copy link

spackbot-app bot commented Jun 1, 2022

Hi @Bitllion! I noticed that the following package(s) don't yet have maintainers:

  • pscmc

Are you interested in adopting any of these package(s)? If so, simply add the following to the package class:

    maintainers = ['Bitllion']

If not, could you contact the developers of this package and see if they are interested? You can quickly see who has worked on a package with spack blame:

$ spack blame pscmc

Thank you for your help! Please don't add maintainers without their consent.

You don't have to be a Spack expert or package developer in order to be a "maintainer," it just gives us a list of users willing to review PRs or debug issues relating to this package. A package can have multiple maintainers; just add a list of GitHub handles of anyone who wants to volunteer.

@spackbot-app
Copy link

spackbot-app bot commented Jun 1, 2022

@Bitllion can you review this PR?

This PR modifies the following package(s), for which you are listed as a maintainer:

  • abacus

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intend to include the abacus package here? These changes are already in #30933

@tldahlgren tldahlgren self-assigned this Jun 1, 2022
@Bitllion
Copy link
Contributor Author

Bitllion commented Jun 1, 2022

Did you intend to include the abacus package here? These changes are already in #30933

Sorry,This is a misunderstanding.
I found a spack stytle errorr on abacus,
Reference to previous version:
from spack import *
I don't know when it was changed to this:
from spack.package import *
Now I have corrected the style error of the abacus branch, but the development branch is still wrong. Because the PSCM branch is just checked out from the development branch, it affects my pscmc branch

@Bitllion Bitllion closed this Jun 1, 2022
@Bitllion Bitllion reopened this Jun 1, 2022
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct the ending copyright year.

var/spack/repos/builtin/packages/pscmc/package.py Outdated Show resolved Hide resolved
Bitllion and others added 2 commits June 6, 2022 13:56
Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
@tldahlgren tldahlgren merged commit adf073b into spack:develop Jun 7, 2022
bhatiaharsh pushed a commit to bhatiaharsh/spack that referenced this pull request Aug 8, 2022
* add some new version of abacus and fix bug on mkl

* Add Package:PSCMC

* update maintainer

* rebase

* update maintainers

* Update var/spack/repos/builtin/packages/pscmc/package.py

Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>

Co-authored-by: Tamara Dahlgren <35777542+tldahlgren@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants