Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS RADIUSS builds #31114

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Conversation

davidbeckingsale
Copy link
Contributor

Adds stacks for a small subset of RADIUSS products on AWS

@spackbot-app spackbot-app bot added the gitlab Issues related to gitlab integration label Jun 13, 2022
@vsoch
Copy link
Member

vsoch commented Jun 13, 2022

🥞

@tldahlgren
Copy link
Contributor

@davidbeckingsale Can you rebase to develop? This PR appears to be suffering from the bootstrap-related failures that have since been fixed.

- chai +cuda +raja
- mfem
- mfem +superlu-dist+petsc+sundials
- mfem +cuda cuda_arch=70
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this spec, it is better to also add ^hypre+cuda (no need to add cuda_arch after this since the mfem package propagates it to hypre).

- mfem
- mfem +superlu-dist+petsc+sundials
- mfem +cuda cuda_arch=70
- mfem +superlu-dist+petsc+sundials+cuda cuda_arch=70
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this spec adding ^hypre+cuda causes issues, so we should not add that.

However, we can add ^superlu-dist+cuda cuda_arch=70 ^petsc+cuda.

Comment on lines 40 to 41
- mfem +cuda cuda_arch=70
- mfem +superlu-dist+petsc+sundials+cuda cuda_arch=70
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two specs can be updated similar to the other updates I mentioned above.

@davidbeckingsale
Copy link
Contributor Author

@v-dobrev seeing a couple of build failures - do you know if these are expected? I might revert to the builds without extra libs for this PR, and we can work on the others later.

@v-dobrev
Copy link
Member

It looks like the PETSc + CUDA configuration step fails with errors like:

*******************************************************************************
         UNABLE to CONFIGURE with GIVEN OPTIONS    (see configure.log for details):
-------------------------------------------------------------------------------
--with-cuda-dir=/home/software/spack/[padded-to-384-chars]/linux-amzn2-aarch64/gcc-7.3.1/cuda-11.7.0-pe4amfjsidlxc2f4hbbvd7g32t2eyafo did not work
*******************************************************************************

on both aarch64 and graviton2.

Another build issue is another PETSc + CUDA configuration step that fails with

*******************************************************************************
         UNABLE to CONFIGURE with GIVEN OPTIONS    (see configure.log for details):
-------------------------------------------------------------------------------
Cannot use SuperLU_DIST with 64 bit BLAS/Lapack indices
*******************************************************************************

on x86_64_v3.

I did test the spec mfem +superlu-dist+petsc+sundials+cuda cuda_arch=70 ^superlu-dist+cuda cuda_arch=70 ^petsc+cuda on Lassen yesterday and it built fine.

Maybe we can just remove the ^petsc+cuda from the spec?

Another option is to just go back to the spec that worked before, removing the newly added ^superlu-dist+cuda cuda_arch=70 ^petsc+cuda.

@vsoch
Copy link
Member

vsoch commented Jun 18, 2022

Moving forward this is going to be challenging because getting any spec right or to build is a moving target - I've found that previously working libraries break rather frequently either with some spack update or a dependency change. I don't know how to consolidate that aside from requiring regular builds.

@v-dobrev
Copy link
Member

@vsoch, you make a good point. My understanding is that all Spack PRs require these checks to pass, so any new PR that breaks things should resolve any such issues. If that is not enforced then builds will remain broken until fixed. I'm not sure what the Spack policy in this regard is.

@davidbeckingsale
Copy link
Contributor Author

I'll try the simpler spec and we can iterate in a future PR.

v-dobrev
v-dobrev previously approved these changes Jun 21, 2022
@vsoch
Copy link
Member

vsoch commented Jun 23, 2022

@davidbeckingsale I'm not sure how to review this - I'd just say tests should be green?

@tldahlgren
Copy link
Contributor

@v-dobrev All of the tests passed. Is this ready to be merged?

@v-dobrev
Copy link
Member

My approval is primarily for the MFEM specs used. For the majority of the other additions, I'm not well qualified to review.

@tldahlgren tldahlgren merged commit 170c605 into spack:develop Jun 28, 2022
@tldahlgren
Copy link
Contributor

My approval is primarily for the MFEM specs used. For the majority of the other additions, I'm not well qualified to review.

No worries. I suspect there will need to be tweaks along the way. Thanks.

bhatiaharsh pushed a commit to bhatiaharsh/spack that referenced this pull request Aug 8, 2022
* Add AWS RADIUSS builds

* Correct variable naming

* Add two more MFEM specs

* Updates to MFEM spec suggested by @v-dobrev

* Simplify MFEM specs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gitlab Issues related to gitlab integration radiuss
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants