-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS RADIUSS builds #31114
AWS RADIUSS builds #31114
Conversation
🥞 |
@davidbeckingsale Can you rebase to develop? This PR appears to be suffering from the bootstrap-related failures that have since been fixed. |
06d5e84
to
2458399
Compare
- chai +cuda +raja | ||
- mfem | ||
- mfem +superlu-dist+petsc+sundials | ||
- mfem +cuda cuda_arch=70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this spec, it is better to also add ^hypre+cuda
(no need to add cuda_arch
after this since the mfem
package propagates it to hypre
).
- mfem | ||
- mfem +superlu-dist+petsc+sundials | ||
- mfem +cuda cuda_arch=70 | ||
- mfem +superlu-dist+petsc+sundials+cuda cuda_arch=70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In this spec adding ^hypre+cuda
causes issues, so we should not add that.
However, we can add ^superlu-dist+cuda cuda_arch=70 ^petsc+cuda
.
- mfem +cuda cuda_arch=70 | ||
- mfem +superlu-dist+petsc+sundials+cuda cuda_arch=70 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two specs can be updated similar to the other updates I mentioned above.
@v-dobrev seeing a couple of build failures - do you know if these are expected? I might revert to the builds without extra libs for this PR, and we can work on the others later. |
It looks like the PETSc + CUDA configuration step fails with errors like:
on both Another build issue is another PETSc + CUDA configuration step that fails with
on I did test the spec Maybe we can just remove the Another option is to just go back to the spec that worked before, removing the newly added |
Moving forward this is going to be challenging because getting any spec right or to build is a moving target - I've found that previously working libraries break rather frequently either with some spack update or a dependency change. I don't know how to consolidate that aside from requiring regular builds. |
@vsoch, you make a good point. My understanding is that all Spack PRs require these checks to pass, so any new PR that breaks things should resolve any such issues. If that is not enforced then builds will remain broken until fixed. I'm not sure what the Spack policy in this regard is. |
I'll try the simpler spec and we can iterate in a future PR. |
f40afe5
to
2e9eb23
Compare
@davidbeckingsale I'm not sure how to review this - I'd just say tests should be green? |
@v-dobrev All of the tests passed. Is this ready to be merged? |
My approval is primarily for the MFEM specs used. For the majority of the other additions, I'm not well qualified to review. |
No worries. I suspect there will need to be tweaks along the way. Thanks. |
* Add AWS RADIUSS builds * Correct variable naming * Add two more MFEM specs * Updates to MFEM spec suggested by @v-dobrev * Simplify MFEM specs
Adds stacks for a small subset of RADIUSS products on AWS