removing feature bloat: monitor and analyzers #31130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
spackbot-app
bot
added
commands
docker
documentation
|
@vsoch Would it be worth considering moving them to a separate repository, as a Spack Python extension? Do you know if that can be done now, or if we need further features / hooks in Spack to be able to do that? |
|
Maybe if/when we need to add something like this again, that would be a better approach to take for next time! |
|
@tgamblin pleeeease review! |
tgamblin
approved these changes
Jul 7, 2022
|
@spackbot run pipeline |
|
I've started that pipeline for you! |
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Jul 15, 2022
alalazo
added a commit
to alalazo/spack
that referenced
this pull request
Jul 18, 2022
bhatiaharsh
pushed a commit
to bhatiaharsh/spack
that referenced
this pull request
Aug 8, 2022
Signed-off-by: vsoch <vsoch@users.noreply.github.com> Co-authored-by: vsoch <vsoch@users.noreply.github.com>
tgamblin
added a commit
that referenced
this pull request
Dec 6, 2022
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
1 task
tgamblin
added a commit
that referenced
this pull request
Dec 6, 2022
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
alalazo
pushed a commit
that referenced
this pull request
Dec 12, 2022
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
alalazo
pushed a commit
that referenced
this pull request
Dec 22, 2022
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
haampie
pushed a commit
that referenced
this pull request
Dec 22, 2022
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
haampie
pushed a commit
that referenced
this pull request
Dec 23, 2022
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
stephenmsachs
pushed a commit
to stephenmsachs/spack
that referenced
this pull request
Jan 3, 2023
These experimental features were removed in spack#31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
haampie
pushed a commit
that referenced
this pull request
Jan 18, 2023
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
haampie
pushed a commit
that referenced
this pull request
Jan 24, 2023
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
RikkiButler20
pushed a commit
to RikkiButler20/spack
that referenced
this pull request
Jan 24, 2023
These experimental features were removed in spack#31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
haampie
pushed a commit
that referenced
this pull request
Feb 7, 2023
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
alalazo
pushed a commit
that referenced
this pull request
Feb 7, 2023
These experimental features were removed in #31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
amd-toolchain-support
pushed a commit
to amd-toolchain-support/spack
that referenced
this pull request
Feb 16, 2023
These experimental features were removed in spack#31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
jmcarcell
pushed a commit
to key4hep/spack
that referenced
this pull request
Apr 13, 2023
These experimental features were removed in spack#31130, but the docs were not. - [x] remove the `spack monitor` and `spack analyze` docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should try to optimize spack to work really well for 80% of use cases, and both of monitor/analyzers don't fall within that. Regardless of the work done they need to be removed! Since I added both of these I want to remove them too :)
Signed-off-by: vsoch vsoch@users.noreply.github.com