Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for git refs as versions #31914

Merged
merged 27 commits into from
Aug 4, 2022
Merged

Add documentation for git refs as versions #31914

merged 27 commits into from
Aug 4, 2022

Conversation

psakievich
Copy link
Contributor

Extending #25981 to the current develop branch and updating for new features such as #31200 #30998 . @becker33 feel free to rework this.

Closes #25981

becker33 and others added 5 commits September 15, 2021 14:55
@becker33
document git commit versions
cdf6b44
@becker33 @haampie
fix variant name in git commit version docs
1779016 
Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
@psakievich
Merge branch 'develop' into docs/git-commit-versions
46c3f8e 
Forgot what I was doing and added some text too
@psakievich
More doc updates
ee8c9d7
@psakievich
Merge branch 'docs/git-commit-versions' into docs/git-version-v19
1687278 
Pull doc changes to the latest version of code
@spackbot-app spackbot-app bot added core PR affects Spack core functionality documentation Improvements or additions to documentation versions labels Aug 3, 2022
becker33
becker33 requested changes Aug 3, 2022
View reviewed changes
lib/spack/docs/basic_usage.rst Outdated Show resolved Hide resolved
lib/spack/docs/environments.rst Outdated Show resolved Hide resolved
lib/spack/spack/version.py Outdated Show resolved Hide resolved
lib/spack/spack/version.py Outdated Show resolved Hide resolved
lib/spack/spack/version.py Outdated Show resolved Hide resolved
lib/spack/spack/version.py Outdated Show resolved Hide resolved
lib/spack/spack/version.py Outdated Show resolved Hide resolved
lib/spack/spack/version.py Outdated Show resolved Hide resolved
lib/spack/spack/version.py Outdated Show resolved Hide resolved
lib/spack/spack/version.py Outdated Show resolved Hide resolved
psakievich and others added 11 commits August 3, 2022 12:39
@psakievich @becker33
Update lib/spack/spack/version.py
ad458a6 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich @becker33
Update lib/spack/docs/basic_usage.rst
f1def73 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich @becker33
Update lib/spack/spack/version.py
60daab7 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich @becker33
Update lib/spack/spack/version.py
6d6da48 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich @becker33
Update lib/spack/spack/version.py
5c7bb57 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich @becker33
Update lib/spack/spack/version.py
df2b0da 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich @becker33
Update lib/spack/spack/version.py
4565ad9 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich @becker33
Update lib/spack/spack/version.py
4a217fb 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich
Reviewer requests
9534b3d
@psakievich
Learing sphinx
e995417
@psakievich
style
5afe06e
becker33
becker33 requested changes Aug 3, 2022
View reviewed changes
Copy link
Member

@becker33 becker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good, thanks for fixing this up!

I think I introduced some typos in my previous suggestions, but otherwise LGTM

lib/spack/docs/basic_usage.rst Outdated Show resolved Hide resolved
lib/spack/docs/environments.rst Outdated Show resolved Hide resolved
lib/spack/spack/version.py Outdated Show resolved Hide resolved
psakievich and others added 3 commits August 3, 2022 15:05
@psakievich @becker33
Update lib/spack/docs/basic_usage.rst
9f219b4 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich @becker33
Update lib/spack/docs/environments.rst
0191f2b 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich @becker33
Update lib/spack/spack/version.py
34b8dc7 
Co-authored-by: Greg Becker <becker33@llnl.gov>
psakievich
psakievich commented Aug 3, 2022
View reviewed changes
lib/spack/spack/version.py Outdated Show resolved Hide resolved
@psakievich psakievich mentioned this pull request Aug 3, 2022
Merged
4 tasks
becker33
becker33 requested changes Aug 3, 2022
View reviewed changes
Copy link
Member

@becker33 becker33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to tighten this up a bit further.

lib/spack/docs/basic_usage.rst Outdated Show resolved Hide resolved
psakievich and others added 2 commits August 3, 2022 15:57
@psakievich @becker33
Update lib/spack/docs/basic_usage.rst
4bd2d49 
Co-authored-by: Greg Becker <becker33@llnl.gov>
@psakievich
Create link
bba26cc
@becker33 becker33 merged commit d67ead5 into spack:develop Aug 4, 2022
@alalazo alalazo mentioned this pull request Aug 4, 2022
Closed
12 tasks
psakievich added a commit to psakievich/spack that referenced this pull request Aug 4, 2022
@psakievich
Fix doc format for code blocks: GitRef versions
88711d5 
Rendering was not pretty using `console` from spack#31914
@psakievich psakievich mentioned this pull request Aug 4, 2022
Merged
becker33 pushed a commit that referenced this pull request Aug 5, 2022
@psakievich
Fix doc format for code blocks: GitRef versions (#31937)
ddc373b 
Rendering was not pretty using `console` from #31914
marcost2 pushed a commit to marcost2/spack that referenced this pull request Aug 26, 2022
@psakievich @becker33
@haampie @marcost2
Add documentation for git refs as versions (spack#31914)
d73e4d8 
* document git commit versions

Include documentation for manually specifying associated known version

* document spack develop command

Co-authorerd-by: psakievich <psakiev@sandia.gov>
Co-authored-by: Gregory Becker <becker33@llnl.gov>
Co-authored-by: Harmen Stoppels <harmenstoppels@gmail.com>
@tldahlgren tldahlgren mentioned this pull request Sep 22, 2022
Merged
@psakievich psakievich deleted the docs/git-version-v19 branch November 8, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@becker33 becker33 becker33 approved these changes

Assignees
No one assigned
Labels
core PR affects Spack core functionality documentation Improvements or additions to documentation versions
Projects
No open projects
Spack v0.18.2 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@psakievich @becker33