Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Construct flake8 excludes for all packages in defined repos #31938

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

greenc-FNAL
Copy link
Member

Construct a --per-file-ignores command line option for flake8 with more
lenient exclusions for packages in each defined repo.

This PR does not cause flake8 (or any other style tool) actually to
check repos not in the prefix tree, but it will apply the usual lenient
exclusions if any packages are checked as a result of non-option
arguments on the spack style command line.

This can be added to this PR if desired.

Notes:

  1. The command line option overrides any per-file-ignores entry in the
    spack/.flake8 configuration file.
  2. We currently use a hardwired list of exclusions in style.py. This
    can be stored in a separate file, or pulled from the main
    per-file-ignores entry in spack/.flake8 if preferred.

@spackbot-app spackbot-app bot added commands core PR affects Spack core functionality labels Aug 4, 2022
@greenc-FNAL greenc-FNAL force-pushed the feature/flake8-use-repo-packages branch from 435b524 to 595cbc2 Compare October 12, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commands core PR affects Spack core functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant