Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the ability to limit the number of versions checksummed. #32030

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Add the ability to limit the number of versions checksummed. #32030

wants to merge 1 commit into from

Conversation

greenc-FNAL
Copy link
Member

  • New command option spack create --limit #.

  • Corresponding functionality in
    spack.stage.get_checksums_for_versions().

@greenc-FNAL
Add the ability to limit the number of versions checksummed.
e642909 
* New command option `spack create --limit #`.

* Corresponding functionality in
  `spack.stage.get_checksums_for_versions()`.
@spackbot-app spackbot-app bot added core PR affects Spack core functionality stage labels Aug 10, 2022
@adamjstewart
Copy link
Member

spack checksum and spack create should already ask you how many versions you would like to checksum. Are you looking for a command line flag to control this to make scripting easier?

@greenc-FNAL
Copy link
Member Author

Exactly. I'm working on a script to generate trees of Perl packages with dependencies, etc. Some Perl packages have dozens of extant versions.

@adamjstewart
Copy link
Member

We'll probably also want to add this feature for spack checksum. Need to add tests too.

@greenc-FNAL
Copy link
Member Author

We'll probably also want to add this feature for spack checksum. Need to add tests too.

Happy to. Didn't see a test to add to, though. Did I miss it, or do I need to test the whole of spack.stage.get_checksums_for_versions()?

@adamjstewart
Copy link
Member

You can add tests to lib/spack/spack/test/cmd/(checksum|create).py

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
checksum Tarball checksum mismatches. commands core PR affects Spack core functionality create-package stage versions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@greenc-FNAL @adamjstewart