Added gemmlowp package #3240
Added gemmlowp package #3240
Conversation
| """Google low-precision matrix multiplication library""" | ||
|
|
||
| homepage = "https://github.com/google/gemmlowp" | ||
| version('a6f29d9ac', git='https://github.com/google/gemmlowp.git', |
There was a problem hiding this comment.
Cal it develop. Same with another package without releases
There was a problem hiding this comment.
The problem with calling it develop is, what happens when someone adds a newer commit? You can't also call that develop.
I think we should ask or encourage the developers to make releases. But obviously we have no control over that. For packages that don't make releases and expect all users to use the latest version, they often don't support problems in older commits. We should honor there wishes and simply install the latest develop or master branch, whichever they recommend.
I would also like to hear @citibeth's thoughts. I know there are security concerns about this approach.
There was a problem hiding this comment.
I would remove a specific commit here. But I fully agree, there should be some releases, even 0.01
There was a problem hiding this comment.
@davydden: we're likely to need more references to specific commits as tensorflow evolves. We only packaged the latest version, so there is only one version here now, but this isn't intended to be a reference to the top of develop. It really is a specific reference.
There was a problem hiding this comment.
Obviously though if the google folks ever add versions we'd use them...
|
Can we keep it please? This issue has already been discussed.
…On Feb 26, 2017 9:29 AM, "Denis Davydov" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In var/spack/repos/builtin/packages/gemmlowp/package.py:
> +# WITHOUT ANY WARRANTY; without even the IMPLIED WARRANTY OF
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the terms and
+# conditions of the GNU Lesser General Public License for more details.
+#
+# You should have received a copy of the GNU Lesser General Public
+# License along with this program; if not, write to the Free Software
+# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+##############################################################################
+from spack import *
+
+
+class Gemmlowp(Package):
+ """Google low-precision matrix multiplication library"""
+
+ homepage = "https://github.com/google/gemmlowp"
+ version('a6f29d9ac', git='https://github.com/google/gemmlowp.git',
I would remove a specific commit here. But I fully agree, there should be
some releases, even 0.01
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3240 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB1cd5mmGIzYw1oTM_U1vAtyzv_DJKrTks5rgYxRgaJpZM4MMJfK>
.
|
|
Hey guys. For the hackathon here, we used specific commit ids because tensorflow wants specific commit ids. It's likely that if we incorporate tensorflow into spack that it will continue to want specific commit ids, and it doesn't seem like Google provides (or will provide soon) versions or releases for these libraries. So in this case the intent is actually not to make this into a "latest release" branch, like we usually use |
There was a problem hiding this comment.
Please change the version download to this:
# No official released versions yet
version('0.0.0.1', git='https://github.com/google/gemmlowp.git',
commit='a6f29d8ac48d63293f845f2253eccbf86bc28321')
Version 0.0.0.1 means "the first Spack release after version 0.0.0", and 0.0.0 means "there are no official releases yet". The advantage of 0.0.0.1 as the version number, rather than using the git hash, is that it will sort. This is the solution we've used in similar cases elsewhere.
|
@citibeth good idea |
|
I'm fine with using git commits as versions if that's how tensorflow works. We lose the ability to sort by version, and we'll need to use |
|
We've used "fake" releases elsewhere. It's not just sorting by version we
lose the ability to do; we lose the ability to control anything by
version. Which is used extensively in our packages.
…On Sun, Feb 26, 2017 at 2:13 PM, Adam J. Stewart ***@***.***> wrote:
I'm fine with using git commits as versions if that's how tensorflow
works. We lose the ability to sort by version, and we'll need to use
preferred=True, but it's better than making our own fake releases. What
happens when someone contacts the developer and complains that they can't
get 0.0.0.1 to install? The developer would be pretty confused. But if we
use the commit hash, it's more descriptive.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3240 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AB1cdz916e6jK0hUowSRDHLtgH1Eh3t-ks5rgc7PgaJpZM4MMJfK>
.
|
No description provided.