Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor lib ext var naming #32653

Merged
merged 3 commits into from
Sep 14, 2022
Merged

Refactor lib ext var naming #32653

merged 3 commits into from
Sep 14, 2022

Conversation

johnwparent
Copy link
Contributor

Fixup issues where packages are unable to find their libraries due to a variable name clash.

Resolves #32651 #32649

@spackbot-app spackbot-app bot added core PR affects Spack core functionality utilities labels Sep 14, 2022
@johnwparent johnwparent mentioned this pull request Sep 14, 2022
Merged
@alalazo
Copy link
Member

alalazo commented Sep 14, 2022

Can you add a unit test?

@johnwparent
Copy link
Contributor Author

Can you add a unit test?

No problem. Doing so now.

@spackbot-app spackbot-app bot added the tests General test capability(ies) label Sep 14, 2022
scheibelp
scheibelp previously approved these changes Sep 14, 2022
View reviewed changes
@scheibelp scheibelp enabled auto-merge (squash) September 14, 2022 19:43
@scheibelp scheibelp merged commit deca346 into spack:develop Sep 14, 2022
@alalazo
Copy link
Member

alalazo commented Sep 15, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scheibelp scheibelp scheibelp approved these changes

@alalazo alalazo Awaiting requested review from alalazo

Assignees
No one assigned
Labels
core PR affects Spack core functionality tests General test capability(ies) utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows rpath support (#31930) breaks "find_libraries"
3 participants
@johnwparent @alalazo @scheibelp