lmod change family arch dir to arch dir

[simonLeary42]

With lmod I get name conflicts for modules in different architecture because the directory structure is family based.

==> Error: Name clashes detected in module files:

file: /modules/spack-0.18.1/share/spack/lmod/linux-ubuntu20.04-x86_64/Core/zlib/1.2.12.lua
spec: zlib@1.2.12%gcc@9.4.0+optimize+pic+shared patches=0d38234 arch=linux-ubuntu20.04-x86_64
spec: zlib@1.2.12%gcc@9.4.0+optimize+pic+shared patches=0d38234 arch=linux-ubuntu20.04-x86_64_v3
spec: zlib@1.2.12%gcc@9.4.0+optimize+pic+shared patches=0d38234 arch=linux-ubuntu20.04-x86_64_v4

With this little change it makes directories for each generic architecture.

[alalazo]

This won't allow people to mix software built for different targets, while you can already do what you ask for by configuring different roots in the modules.yaml, see https://spack.readthedocs.io/en/latest/module_file_support.html#changing-the-modules-root

[simonLeary42]

That would result in a structure like this:

$spack/share/spack/modules/x86_64/linux-ubuntu-20.04/x86_64
$spack/share/spack/modules/x86_64_v3/linux-ubuntu-20.04/x86_64
$spack/share/spack/modules/x86_64_v4/linux-ubuntu-20.04/x86_64

which is rather ugly.

Why would anyone want to mix targets in a single directory? Can they mix like that in TCL?

[bernhardkaindl]

Closing due to lack of response on the review. A different way of doing this has been suggested.
Please reopen if needed still.

[simonLeary42]

spack/lib/spack/spack/modules/common.py

Line 635 in 85966a9

arch_folder = str(self.spec.architecture)

The TCL modules use the arch dir, so shouldn't the Lmod modules be consistent?

[simonLeary42]

@alalazo can we revisit this?

[simonLeary42]

One could mix modules from different targets by simply setting modules:default:arch_folder=false