Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latest versions to metkit, fdb packages #33289

Merged
merged 12 commits into from Nov 25, 2022
Merged

Add latest versions to metkit, fdb packages #33289

merged 12 commits into from Nov 25, 2022

Conversation

victoria-cherkas
Copy link
Contributor

@victoria-cherkas victoria-cherkas commented Oct 13, 2022

Changes:

  • Add 1.9.2 version to metkit package
  • Add master and 5.10.8 versions to the fdb package

Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed all three sha256. Suggested a couple of minor fixes.

var/spack/repos/builtin/packages/fdb/package.py Outdated Show resolved Hide resolved
var/spack/repos/builtin/packages/fdb/package.py Outdated Show resolved Hide resolved
@tldahlgren tldahlgren self-assigned this Oct 13, 2022
@skosukhin
Copy link
Member

  1. eckit: update versions #33200 adds version 1.20.2 of eckit. Could you, please, decide together with @PanicSheep on who goes first?
  2. Do all new versions pass the tests when installed with Spack (spack install --test=root <package>)?

@dominichofer
Copy link
Contributor

I will take care of eckit in #33200.

@victoria-cherkas
Copy link
Contributor Author

./spack install --test=root metkit@1.9.2 is successful.
./spack install --test=root fdb is not - looking into it.

@victoria-cherkas victoria-cherkas changed the title Add latest versions to eckit, metkit, fdb packages Add latest versions to metkit, fdb packages Oct 14, 2022
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reconfirmed new sha256.

tldahlgren
tldahlgren previously approved these changes Oct 14, 2022
Copy link
Contributor

@tldahlgren tldahlgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM.

@tldahlgren
Copy link
Contributor

Will defer merge decision and timing to @skosukhin

@alalazo
Copy link
Member

alalazo commented Nov 7, 2022

@skosukhin

@skosukhin
Copy link
Member

This seems to be missing depends_on("eckit@1.20:", when="@5.10.8:") (my tests show that eckit@1.19.0 should be fine for fdb@5.10.7, so it's really @5.10.8:). This means that this PR can be merged only after #33200.

Also, spack install fdb ^eckit@1.20.2 fails with:

/usr/bin/ld: /scratch/local1/spack/opt/spack/linux-debian11-skylake/gcc-10.2.1/eckit-1.20.2-5hc2cac5ubg3s767mlnpm3g6hsbu3btn/lib/libeckit_cmd.so: undefined reference to `setupterm'
/usr/bin/ld: /scratch/local1/spack/opt/spack/linux-debian11-skylake/gcc-10.2.1/eckit-1.20.2-5hc2cac5ubg3s767mlnpm3g6hsbu3btn/lib/libeckit_cmd.so: undefined reference to `tputs'
/usr/bin/ld: /scratch/local1/spack/opt/spack/linux-debian11-skylake/gcc-10.2.1/eckit-1.20.2-5hc2cac5ubg3s767mlnpm3g6hsbu3btn/lib/libeckit_cmd.so: undefined reference to `cur_term'
collect2: error: ld returned 1 exit status

We need a patch/conflict/workaround for that.

@skosukhin
Copy link
Member

skosukhin commented Nov 7, 2022

The underlinking problem is fixed in #33739.

Copy link
Contributor

@bernhardkaindl bernhardkaindl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The referenced PRs #33200 and #33739 are merged now, so AFAICS, we can merge this

@bernhardkaindl bernhardkaindl merged commit 1ed1b49 into spack:develop Nov 25, 2022
@skosukhin
Copy link
Member

@bernhardkaindl impatience and inattention feel I :)

@victoria-cherkas
Copy link
Contributor Author

Hi @skosukhin should I create an additional PR for the depends_on("eckit@1.20:", when="@5.10.8:") and anything else? Or is this already under control elsewhere?

@skosukhin
Copy link
Member

@victoria-cherkas please, create an additional PR. Thank you. Very much appreciated.

amd-toolchain-support pushed a commit to amd-toolchain-support/spack that referenced this pull request Feb 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants